Support deleting symlinks in Lwt_io.with_temp_dir on Windows #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MisterDA Could you rebase this? |
MisterDA
force-pushed
the
with-temp-dir-symlinks
branch
from
cd95cc4
to
ce82439
Compare
|
Rebased. |
smorimoto
approved these changes
Oct 6, 2021
|
Thanks! |
|
This is related to ocaml/ocaml#10642. At the moment neither |
If a Windows symlink points to a directory, then rmdir is the correct function to call. If it points to a file, then unlink is the correct function. When pointing to a file, the symlink can also have the read-only attribute, which makes it subject of the little chmod dance.
smorimoto
force-pushed
the
with-temp-dir-symlinks
branch
from
ce82439
to
e902075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Windows symlink points to a directory, then rmdir is the correct
function to call. If it points to a file, then unlink is the correct
function. When pointing to a file, the symlink can also have the
read-only attribute, which makes it subject of the little chmod dance.
This depends on the fix in #883.