Skip to content

Commit

Permalink
Lock file maintenance (#348)
Browse files Browse the repository at this point in the history
* Lock file maintenance

* remove eslint-config-kentcdodds in favor of eslint-config-next

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Mario Beltrán Alarcón <belco90@gmail.com>
  • Loading branch information
3 people committed Sep 7, 2021
1 parent b02c6af commit d6e1b05
Show file tree
Hide file tree
Showing 4 changed files with 126 additions and 664 deletions.
26 changes: 11 additions & 15 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,8 @@ module.exports = {
root: true,
parser: '@typescript-eslint/parser',
extends: [
'kentcdodds/deprecated-rules',
'kentcdodds/stylistic',
'kentcdodds/best-practices',
'kentcdodds/possible-errors',
'kentcdodds/es6',
'kentcdodds/react',
'kentcdodds/jsx-a11y',
'eslint:recommended',
'plugin:@typescript-eslint/recommended',
'next',
'prettier',
],
Expand All @@ -22,19 +17,20 @@ module.exports = {
},
rules: {
// Base
'no-shadow': 2,
'no-warning-comments': 0,
'no-shadow': 'error',
'no-warning-comments': 'off',

// React
'react/self-closing-comp': 2,
'react/react-in-jsx-scope': 0,
'react/self-closing-comp': 'error',
'react/react-in-jsx-scope': 'off',

// TypeScript
// Disabling these rules temporary until types are properly defined across
// the whole codebase.
'@typescript-eslint/no-unsafe-assignment': 0,
'@typescript-eslint/no-unsafe-argument': 0,
'@typescript-eslint/no-unsafe-assignment': 'off',
'@typescript-eslint/no-unsafe-argument': 'off',

'@typescript-eslint/explicit-module-boundary-types': 'off',
'@typescript-eslint/array-type': [
'error',
{
Expand All @@ -43,9 +39,9 @@ module.exports = {
],

// Import
'import/newline-after-import': 2,
'import/newline-after-import': 'error',
'import/order': [
2,
'error',
{
'newlines-between': 'always',
alphabetize: {
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"@typescript-eslint/parser": "4.30.0",
"babel-eslint": "10.1.0",
"eslint": "7.32.0",
"eslint-config-kentcdodds": "19.2.0",
"eslint-config-next": "11.1.2",
"eslint-config-prettier": "8.3.0",
"eslint-import-resolver-typescript": "2.4.0",
Expand Down
2 changes: 1 addition & 1 deletion src/contexts/comparator-context.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const ComparatorProvider = ({ children }: { children: ReactNode }) => {
...newFilters,
}
const newQuery = Object.fromEntries(
Object.entries(mergedFilters).filter(([_, value]) => Boolean(value))
Object.entries(mergedFilters).filter(([, value]) => Boolean(value))
)

void router.replace(
Expand Down

0 comments on commit d6e1b05

Please sign in to comment.