feat: v5 #563

wolfy1339 · 2023-05-21T22:50:37Z

BREAKING CHANGE: Drop support for NodeJS v14, v16
BREAKING CHANGE: Remove previews support for the REST API
BREAKING CHANGE: remove agent option from octokit.request()

* build(package): set minimal node version in engines field to v18 * build: update esbuild options to use Node 18 BREAKING CHANGE: Drop support for NodeJS v14, v16

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>

wolfy1339 · 2023-06-18T19:36:43Z

I'm having trouble getting the tests to pass. Can someone take a look?

wolfy1339 · 2023-07-07T20:12:03Z

I was thinking of doing it that way.

Going through the dependencies of @octokit/core first to the very bottom of it's dependency graph, and going up from there.

Then @octokit/rest's dependency graph to the very bottom.

Then, octokit.js' dependency graph

We should catch most of the packages this way.

For those that didn't get caught, we follow the method outlined in the other discussion

wolfy1339 · 2023-07-07T20:27:02Z

I have found this neat tool to visualize the dependency graph of NPM packages,
https://npmgraph.js.org/

kfcampbell · 2023-07-07T20:39:30Z

Oh my gosh, that tool is awesome, this is super useful.

It looks like the next step is octokit/auth-token.js#354.

wolfy1339 · 2023-07-07T22:09:24Z

Alright, this seems good to go

Only thing that needs to be looked at are the tests

nickfloyd · 2023-07-10T15:10:29Z

package.json

    "@octokit/tsconfig": "^2.0.0",
    "@types/fetch-mock": "^7.3.1",
    "@types/jest": "^29.0.0",
    "@types/lolex": "^5.1.0",
    "@types/node": "^18.0.0",
    "esbuild": "^0.18.0",
-    "fetch-mock": "^9.0.0",
+    "fetch-mock": "npm:@gr2m/fetch-mock@9.11.0-pull-request-644.1",


It would be nice to see this get merged into fetch-mock - any thoughts on what might be holding that up (since Sept 2022)?

The alias is fine, but it does seem like the project isn't even in maintenance mode - given the last commit to master was almost 2 years ago. Are there any alternatives to this mocking framework that would make for an easy migration and get us the functionality that we need here?

I don't know of any alternatives at the moment.

nickfloyd · 2023-07-10T15:13:35Z

Only thing that needs to be looked at are the tests

I'll take a look at these today @wolfy1339. I assume it's just the ones you put a skip on in the commit tree, correct?

I'll post what I find.

wolfy1339 · 2023-07-10T15:49:33Z

Only thing that needs to be looked at are the tests

I'll take a look at these today @wolfy1339. I assume it's just the ones you put a skip on in the commit tree, correct?

I'll post what I find.

Yes, it's the ones I put a skip on

gr2m · 2023-07-10T16:57:17Z

test/constructor.test.ts

    const mock = fetchMock.sandbox().getOnce(
-      "https://api.github.com/",
+      "https://api.github.com/graphql",


can we update the test to something real? At least we should use POST /graphql. I think the GraphQL API supports get requests technically, but we always use POST /graphql.

test/graphql.test.ts

gr2m · 2023-07-10T16:59:37Z

test/request.test.ts

      .getOnce(
-        "https://api.github.com/",
+        "https://api.github.com/graphql",


same as above, let's use POST

gr2m · 2023-07-10T17:00:13Z

test/request.test.ts

      request: {
        fetch: mock,
      },
    });

-    await octokit.request("/");
-    await octokit.request("/", {
+    await octokit.request("/graphql", {


Thinking more about it, maybe we should move these tests to test/graphql.test.ts now?

I'll look into hoisting them out once I get past the skips. We could also differ it to another change set so we can move forward here. Not like the change would be hard, it just introduces more into something we've been trying to get out the door.

agree, this can totally be a follow up, like all of my comments

gr2m

I think this is good to go, all my comments above can be addressed in follow ups

github-actions · 2023-07-10T19:12:24Z

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ci: stop testing against NodeJS v14, v16 (#561)

11d6862

* build(package): set minimal node version in engines field to v18 * build: update esbuild options to use Node 18 BREAKING CHANGE: Drop support for NodeJS v14, v16

wolfy1339 added Type: Feature New feature or request Type: Breaking change Used to note any change that requires a major version bump labels May 21, 2023

ghost added this to Features in JS May 21, 2023

nickfloyd and others added 3 commits May 25, 2023 11:21

Merge branch 'main' into beta

41cbcdc

fix(deps): update dependency @octokit/request-error to v4 (#565)

0122b69

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: bump @octokit/request-error to v4.0.1

819646a

NOUIY mentioned this pull request Jun 7, 2023

[Snyk] Upgrade @octokit/request from 6.0.1 to 6.2.4 NOUIY/core.js#146

Open

Merge branch 'main' into beta

6fb43c4

NOUIY mentioned this pull request Jun 8, 2023

[Snyk] Upgrade @octokit/request from 6.0.1 to 6.2.5 NOUIY/core.js#147

Open

wolfy1339 and others added 2 commits June 13, 2023 20:40

Merge branch 'main' into beta

5dca843

fix(deps): update dependency @octokit/types to v10 (#571)

5a5776d

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>

NOUIY mentioned this pull request Jun 14, 2023

[Snyk] Upgrade @octokit/request from 6.0.1 to 6.2.5 NOUIY/core.js#150

Open

wolfy1339 mentioned this pull request Jun 16, 2023

fix(deps): update dependency @octokit/request-error to v4 #572

Merged

1 task

wolfy1339 added 3 commits June 16, 2023 18:10

Merge branch 'main' into beta

7627a33

fix(deps): bump Octokit deps

db76bdb

fix(deps): upgrade @octokit/graphql to beta

d267580

This comment was marked as resolved.

Sign in to view

wolfy1339 added 2 commits June 18, 2023 14:17

fix: bump @octokit/graphql

5f043aa

build(lockfile): upgrade @octokit/endpoint to v8.0.1

6ce4d38

wolfy1339 marked this pull request as ready for review June 18, 2023 18:19

wolfy1339 added 3 commits June 18, 2023 15:01

test: replace @octokit/auth with proper packages

4311080

test: use graphql endpoint for previews

6aeab0a

test: fix last commit

4fa71b4

test: fix preview test

8b0dc00

wolfy1339 added 4 commits July 7, 2023 17:48

fix(deps): upgrade @octokit packages

4e934d2

style: prettier

6974fd6

test: skip agent tests

29f04aa

test: add fixme comments

e91e8a4

wolfy1339 requested review from kfcampbell and gr2m July 7, 2023 23:34

build(deps): upgrade Octokit deps

71ca7a8

NOUIY mentioned this pull request Jul 9, 2023

[Snyk] Upgrade @octokit/request from 6.0.1 to 6.2.8 NOUIY/core.js#153

Open

nickfloyd reviewed Jul 10, 2023

View reviewed changes

gr2m reviewed Jul 10, 2023

View reviewed changes

test/graphql.test.ts Show resolved Hide resolved

gr2m reviewed Jul 10, 2023

View reviewed changes

gr2m approved these changes Jul 10, 2023

View reviewed changes

wolfy1339 merged commit 0b4ad1e into main Jul 10, 2023
9 checks passed

wolfy1339 deleted the beta branch July 10, 2023 19:11

github-actions bot added the released label Jul 10, 2023

This was referenced Jul 10, 2023

Rewrites the ca tests to use the dispatcher and custom fetch #584

Closed

Rewrites the ca tests to use the dispatcher and custom fetch #585

Merged

wolfy1339 mentioned this pull request Jul 10, 2023

feat: v20 octokit/rest.js#305

Merged

nickfloyd mentioned this pull request Jul 13, 2023

fix(deps): update octokit monorepo (major) octokit/action.js#513

Merged

1 task

oscard0m mentioned this pull request Jul 15, 2023

Avoid JSON.stringify hack when testing responses of fetch-mock #588

Closed

5 tasks

NOUIY mentioned this pull request Sep 23, 2023

[Snyk] Upgrade @octokit/request from 6.0.1 to 6.2.8 NOUIY/core.js#154

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: v5 #563

feat: v5 #563

wolfy1339 commented May 21, 2023 •

edited

This comment was marked as resolved.

wolfy1339 commented Jun 18, 2023

wolfy1339 commented Jul 7, 2023 •

edited

wolfy1339 commented Jul 7, 2023 •

edited

kfcampbell commented Jul 7, 2023

wolfy1339 commented Jul 7, 2023

nickfloyd Jul 10, 2023

wolfy1339 Jul 10, 2023

nickfloyd commented Jul 10, 2023

wolfy1339 commented Jul 10, 2023

gr2m Jul 10, 2023

gr2m Jul 10, 2023

gr2m Jul 10, 2023

nickfloyd Jul 10, 2023 •

edited

gr2m Jul 10, 2023

gr2m left a comment

github-actions bot commented Jul 10, 2023

feat: v5 #563

feat: v5 #563

Conversation

wolfy1339 commented May 21, 2023 • edited

This comment was marked as resolved.

wolfy1339 commented Jun 18, 2023

wolfy1339 commented Jul 7, 2023 • edited

wolfy1339 commented Jul 7, 2023 • edited

kfcampbell commented Jul 7, 2023

wolfy1339 commented Jul 7, 2023

nickfloyd Jul 10, 2023

Choose a reason for hiding this comment

wolfy1339 Jul 10, 2023

Choose a reason for hiding this comment

nickfloyd commented Jul 10, 2023

wolfy1339 commented Jul 10, 2023

gr2m Jul 10, 2023

Choose a reason for hiding this comment

gr2m Jul 10, 2023

Choose a reason for hiding this comment

gr2m Jul 10, 2023

Choose a reason for hiding this comment

nickfloyd Jul 10, 2023 • edited

Choose a reason for hiding this comment

gr2m Jul 10, 2023

Choose a reason for hiding this comment

gr2m left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 10, 2023

wolfy1339 commented May 21, 2023 •

edited

wolfy1339 commented Jul 7, 2023 •

edited

wolfy1339 commented Jul 7, 2023 •

edited

nickfloyd Jul 10, 2023 •

edited