Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @octokit/fixtures to v22.0.7 - autoclosed #340

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 25, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@octokit/fixtures 22.0.6 -> 22.0.7 age adoption passing confidence

Release Notes

octokit/fixtures (@​octokit/fixtures)

v22.0.7

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 25, 2024
@wolfy1339
Copy link
Member

Hmm... Something odd is going on with the binary response test

@renovate renovate bot force-pushed the renovate/octokit-monorepo branch from 57af66e to b939437 Compare January 30, 2024 11:25
@nickfloyd
Copy link
Contributor

nickfloyd commented Feb 1, 2024

404 makes me think we either lost access to the resource (but why just that resource/endpoint) or the endpoint is no longer valid (which would be pretty rare)

@renovate renovate bot force-pushed the renovate/octokit-monorepo branch from b939437 to 07bf0fc Compare February 6, 2024 06:53
@renovate renovate bot force-pushed the renovate/octokit-monorepo branch 3 times, most recently from 897f3a4 to 0f27a84 Compare February 20, 2024 06:14
@renovate renovate bot force-pushed the renovate/octokit-monorepo branch 2 times, most recently from ff4ad39 to 361b19e Compare February 27, 2024 18:40
@nickfloyd
Copy link
Contributor

nickfloyd commented Feb 29, 2024

Tests run ✅ on main. I'm looking into what might be happening. It's breaking after this update to fixtures was used - where a snapshot got updated

@nickfloyd
Copy link
Contributor

I found the cause, though I am not exactally sure why it's behaving like it is.

Turns out the test does not like this line and this line - i.e.
"accept-encoding": "gzip, compress, deflate, br",

The header is an acceptable request header, the values are correct. It might have something to do with how express is handling content negotiation. I'll check other fixtures to see if we use encoding headers anywhere else.

@renovate renovate bot force-pushed the renovate/octokit-monorepo branch from 361b19e to 2c5e125 Compare March 5, 2024 07:24
@renovate renovate bot force-pushed the renovate/octokit-monorepo branch 3 times, most recently from 8309ef4 to 0bb3c0c Compare March 19, 2024 06:48
@renovate renovate bot force-pushed the renovate/octokit-monorepo branch 4 times, most recently from dfe42d9 to 0536c33 Compare March 27, 2024 18:35
@renovate renovate bot force-pushed the renovate/octokit-monorepo branch 2 times, most recently from a0da0ff to 24916b2 Compare April 3, 2024 18:06
@renovate renovate bot force-pushed the renovate/octokit-monorepo branch from 24916b2 to 6cfb955 Compare April 9, 2024 08:02
@renovate renovate bot force-pushed the renovate/octokit-monorepo branch from 6cfb955 to b4528f6 Compare April 9, 2024 22:33
@wolfy1339
Copy link
Member

The problem seems to lie further, express handles the request just fine. From the error, it's something to do with Nock

@wolfy1339
Copy link
Member

😅 I figured it out. It's much simpler than we thought

We only had to add the header to the requests in https://github.com/octokit/fixtures-server/blob/main/test/integration/binary-response.test.js

@renovate renovate bot changed the title fix(deps): update dependency @octokit/fixtures to v22.0.7 fix(deps): update dependency @octokit/fixtures to v22.0.7 - autoclosed Apr 10, 2024
@renovate renovate bot closed this Apr 10, 2024
@renovate renovate bot deleted the renovate/octokit-monorepo branch April 10, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants