-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency @octokit/fixtures to v22.0.7 - autoclosed #340
Conversation
Hmm... Something odd is going on with the binary response test |
57af66e
to
b939437
Compare
404 makes me think we either lost access to the resource (but why just that resource/endpoint) or the endpoint is no longer valid (which would be pretty rare) |
b939437
to
07bf0fc
Compare
897f3a4
to
0f27a84
Compare
ff4ad39
to
361b19e
Compare
Tests run ✅ on main. I'm looking into what might be happening. It's breaking after this update to fixtures was used - where a snapshot got updated |
I found the cause, though I am not exactally sure why it's behaving like it is. Turns out the test does not like this line and this line - i.e. The header is an acceptable request header, the values are correct. It might have something to do with how express is handling content negotiation. I'll check other fixtures to see if we use encoding headers anywhere else. |
361b19e
to
2c5e125
Compare
8309ef4
to
0bb3c0c
Compare
dfe42d9
to
0536c33
Compare
a0da0ff
to
24916b2
Compare
24916b2
to
6cfb955
Compare
6cfb955
to
b4528f6
Compare
The problem seems to lie further, express handles the request just fine. From the error, it's something to do with Nock |
😅 I figured it out. It's much simpler than we thought We only had to add the header to the requests in https://github.com/octokit/fixtures-server/blob/main/test/integration/binary-response.test.js |
This PR contains the following updates:
22.0.6
->22.0.7
Release Notes
octokit/fixtures (@octokit/fixtures)
v22.0.7
Compare Source
Bug Fixes
get-achive
snapshots (#630) (3171ddc), closes #629Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.