Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix build #255

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

attempt to fix build #255

wants to merge 14 commits into from

Conversation

kfcampbell
Copy link
Member

@kfcampbell kfcampbell commented Jan 24, 2024

Work-in-progress experiments to fix the broken builds on this repo.

This PR:

  • tests using Node 20 instead of Node 18
  • Gets the latest version of vercel/ncc
  • Explicitly updates the octokit/action version to ^6.0.7
  • Adds a workflow_dispatch trigger for the test Action

Copy link

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@kfcampbell kfcampbell changed the title Add workflow_dispatch trigger WIP attempt to fix build Jan 24, 2024
@kfcampbell kfcampbell changed the title WIP attempt to fix build attempt to fix build Jan 25, 2024
@gr2m
Copy link
Contributor

gr2m commented Jan 28, 2024

I would recommend to use https://github.com/actions/create-github-app-token/ as a reference, that's how I'd setup actions these days. esbuild creates much more readable build files, is faster, and simpler. And as actions support Node 20 now, we can use ES Modules.

@wolfy1339

This comment was marked as resolved.

@wolfy1339
Copy link
Member

wolfy1339 commented Apr 17, 2024

Bumping it to use the NodeJS 20 runner fixed things.

The problem is that undici requires NodeJS >= 18 as of now: https://github.com/nodejs/undici/blob/v6.13.0/package.json#L128

Undici was introduced via @octokit/action v6

@wolfy1339 wolfy1339 marked this pull request as ready for review April 17, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants