Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not require state parameter to create a token #288

Merged
merged 1 commit into from Jun 22, 2022
Merged

fix: do not require state parameter to create a token #288

merged 1 commit into from Jun 22, 2022

Conversation

baoshan
Copy link
Contributor

@baoshan baoshan commented Jun 22, 2022

I’ll rebase #287 once this one is approved.

Thanks.

@ghost ghost added this to Inbox in JS Jun 22, 2022
@gr2m gr2m added the Type: Bug Something isn't working as documented label Jun 22, 2022
@ghost ghost moved this from Inbox to Bugs in JS Jun 22, 2022
gr2m
gr2m approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great PR, thank you!!

@gr2m gr2m merged commit f14c68e into octokit:master Jun 22, 2022
JS automation moved this from Bugs to Done Jun 22, 2022
@github-actions
Copy link

🎉 This PR is included in version 3.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

wolfy1339 added a commit that referenced this pull request Jul 8, 2022
@wolfy1339
fix: revert "fix: do not require state parameter to create a token (#…
7cf2144 
…288)"

This reverts commit f14c68e.
@oscard0m oscard0m mentioned this pull request Jul 8, 2022
Closed
1 task
@wolfy1339 wolfy1339 mentioned this pull request Jul 8, 2022
Closed
@wolfy1339
Copy link
Member

Hey @baoshan it seems that this PR introduced a regression and needed to be reverted, I opened #308 so we can discuss more there

wolfy1339 added a commit that referenced this pull request Jul 8, 2022
@wolfy1339
fix: revert "fix: do not require state parameter to create a token (#…
ff82e60 
…288)"

Reverted due to introducing a regression
This reverts commit f14c68e.
@baoshan baoshan deleted the no_state_for_create_token branch August 31, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@baoshan @wolfy1339 @gr2m