fix(deps): update dependency @octokit/oauth-app to v4

[renovate]

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@octokit/oauth-app	^3.3.2 -> ^4.0.0

---

Release Notes

octokit/oauth-app.js

v4.0.4

Compare Source

Bug Fixes

• deps: update dependency @​octokit/oauth-methods to v2 (#​306) (63d07dc)

v4.0.3

Compare Source

Bug Fixes

• deps: update dependency @​octokit/auth-oauth-user to v2 (#​305) (84a940c)

v4.0.2

Compare Source

Bug Fixes

• deps: update dependency @​octokit/auth-unauthenticated to v3 (#​303) (29dac74)

v4.0.1

Compare Source

Bug Fixes

• deps: update dependency @​octokit/core to v4 (#​304) (7d7b6e7)

v4.0.0

Compare Source

Continuous Integration

• stop testing against NodeJS v10, v12 (#​302) (fb91bd6)

BREAKING CHANGES

• Drop support for NodeJS v10, v12

v3.7.1

Compare Source

Bug Fixes

• revert "fix: do not require state parameter to create a token (#​288)" (7cf2144)

v3.7.0

Compare Source

Features

• createWebWorkerHandler for Cloudflare and Deno. Deprecates createCloudflareHandler (#​287) (31b3f70)

v3.6.3

Compare Source

Bug Fixes

• do not require state parameter to create a token (#​288) (f14c68e)

v3.6.2

Compare Source

Bug Fixes

• use type import for aws-lambda (#​284) (7eaf81d), closes #​283

v3.6.1

Compare Source

Bug Fixes

• use type import for aws-lambda (#​283) (71c952d)

---

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by Mend Renovate. View repository job log here.

[wolfy1339]

The tests are failing because of this dependency

FAIL test/readme-examples.test.ts (5.301 s)
  ● Console
    console.warn
      Unmatched POST to https://github.com/login/oauth/access_token
      at Function.Object.<anonymous>.FetchMock.executeRouter (node_modules/fetch-mock/cjs/lib/fetch-handler.js:221:11)
      at Function.Object.<anonymous>.FetchMock._fetchHandler (node_modules/fetch-mock/cjs/lib/fetch-handler.js:144:34)
      at Function.Object.<anonymous>.FetchMock.fetchHandler (node_modules/fetch-mock/cjs/lib/fetch-handler.js:135:14)
      at fetchMockProxy (node_modules/fetch-mock/cjs/lib/index.js:52:51)
      at fetch (node_modules/@octokit/core/node_modules/@octokit/request/dist-src/fetch-wrapper.js:17:12)
      at fetchWrapper (node_modules/@octokit/core/node_modules/@octokit/request/dist-src/with-defaults.js:10:20)
      at request (node_modules/@octokit/auth-oauth-app/dist-src/hook.js:7:16)
      at node_modules/before-after-hook/lib/register.js:25:15
    console.error
      RequestError [HttpError]: Unknown error: {"error":"fetch-mock: No fallback response defined for POST to https://github.com/login/oauth/access_token"}
          at /home/runner/work/app.js/app.js/node_modules/@octokit/request/dist-src/fetch-wrapper.js:68:27
          at processTicksAndRejections (node:internal/process/task_queues:95:5)
          at Object.<anonymous> (/home/runner/work/app.js/app.js/test/readme-examples.test.ts:296:5) {
        status: 400,
        response: {
          url: 'http://localhost:39771/api/github/oauth/callback?code=code123&state=state123',
          status: 400,
          headers: {
            'access-control-allow-origin': '*',
            connection: 'close',
            'content-type': 'application/json',
            date: 'Fri, 08 Jul 2022 06:16:26 GMT',
            'transfer-encoding': 'chunked'
          },
          data: {
            error: 'fetch-mock: No fallback response defined for POST to https://github.com/login/oauth/access_token'
          }
        },
        request: {
          method: 'GET',
          url: 'http://localhost:39771/api/github/oauth/callback?code=code123&state=state123',
          headers: {
            accept: 'application/vnd.github.v3+json',
            'user-agent': 'octokit-request.js/5.6.3 Node.js/18.4.0 (linux; x64)'
          }
        }
      }
      294 |     const { port } = server.address();
      295 |
    > 296 |     await request(`http://localhost:${port}/api/github/oauth/callback`, {
          |     ^
      297 |       code: "code123",
      298 |       state: "state123",
      299 |     }).catch(console.error);
      at Object.<anonymous> (test/readme-examples.test.ts:296:5)
    console.warn
      Warning: https://github.com/login/oauth/access_token not called
      301 |     server.close();
      302 |
    > 303 |     expect(mock.done()).toBe(true);
          |                 ^
      304 |   });
      305 | });
      306 |
      at node_modules/fetch-mock/cjs/lib/inspecting.js:177:13
          at Array.map (<anonymous>)
      at Function.<anonymous> (node_modules/fetch-mock/cjs/lib/inspecting.js:174:4)
      at Function.done (node_modules/fetch-mock/cjs/lib/inspecting.js:21:23)
      at Object.<anonymous> (test/readme-examples.test.ts:303:17)
    console.warn
      Warning: path:/user not called
      301 |     server.close();
      302 |
    > 303 |     expect(mock.done()).toBe(true);
          |                 ^
      304 |   });
      305 | });
      306 |
      at node_modules/fetch-mock/cjs/lib/inspecting.js:177:13
          at Array.map (<anonymous>)
      at Function.<anonymous> (node_modules/fetch-mock/cjs/lib/inspecting.js:174:4)
      at Function.done (node_modules/fetch-mock/cjs/lib/inspecting.js:21:23)
      at Object.<anonymous> (test/readme-examples.test.ts:303:17)
  ● README examples › app.oauth.on("token", handler)
    expect(received).toBe(expected) // Object.is equality
    Expected: true
    Received: false
      301 |     server.close();
      302 |
    > 303 |     expect(mock.done()).toBe(true);
          |                         ^
      304 |   });
      305 | });
      306 |
      at Object.<anonymous> (test/readme-examples.test.ts:303:25)
  ● README examples › app.oauth.on("token", handler)
    expect.assertions(2)
    Expected two assertions to be called but received one assertion call.
      253 |
      254 |   test('app.oauth.on("token", handler)', async () => {
    > 255 |     expect.assertions(2);
          |            ^
      256 |
      257 |     mock
      258 |       .postOnce(
      at Object.<anonymous> (test/readme-examples.test.ts:255:12)

[oscard0m]

The tests are failing because of this dependency

Checking it right now 💪🏽

[oscard0m]

A regression was introduced in @octokit/oauth-app.js v3.6.3:

• v3.6.3 checks failing ❌ : WIP build(deps): upgrade @octokit/oauth-app.js to v3.6.3 #307
• v3.6.2 checks passing ✅ : WIP build(deps): upgrade @octokit/oauth-app.js to 3.6.2 #308

We need to create a bug to properly address the regression but, what should be the procedure now? A release of v3.6.4 with the fix? Should we unpublish v4? @wolfy1339

[wolfy1339]

We can publish a revert to both v4 and v3

[oscard0m]

We can publish a revert to both v4 and v3

@wolfy1339 Do you know what was the expected output here? octokit/oauth-app.js#288
a) Get rid of state property
b) Make state property optional (only pass it if defined)

[github-actions]

🎉 This issue has been resolved in version 13.0.4 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀