fix: remove unused state option in exchangeWebFlowCode() (#52)

Co-authored-by: Roman Balayan <roman.balayan@paymaya.com>
octokit · Oct 11, 2021 · ceb5ee8 · ceb5ee8
1 parent 4d86a2d
commit ceb5ee8
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 24 deletions.
diff --git a/README.md b/README.md
@@ -459,17 +459,6 @@ Options
         The <code>redirectUrl</code> option you passed to <a href="#getwebflowauthorizationurl"><code>getWebFlowAuthorizationUrl()</code></a>
       </td>
     </tr>
-    <tr>
-      <th>
-        <code>state</code>
-      </th>
-      <th>
-        <code>string</code>
-      </th>
-      <td>
-        The <code>state</code> option you passed to <a href="#getwebflowauthorizationurl"><code>getWebFlowAuthorizationUrl()</code></a>
-      </td>
-    </tr>
     <tr>
       <th>
         <code>request</code>

diff --git a/src/exchange-web-flow-code.ts b/src/exchange-web-flow-code.ts
@@ -18,7 +18,6 @@ export type ExchangeWebFlowCodeOAuthAppOptions = {
   clientSecret: string;
   code: string;
   redirectUrl?: string;
-  state?: string;
   request?: RequestInterface;
 };
 export type ExchangeWebFlowCodeGitHubAppOptions = {
@@ -27,7 +26,6 @@ export type ExchangeWebFlowCodeGitHubAppOptions = {
   clientSecret: string;
   code: string;
   redirectUrl?: string;
-  state?: string;
   request?: RequestInterface;
 };
 
@@ -77,7 +75,6 @@ export async function exchangeWebFlowCode(
       client_secret: options.clientSecret,
       code: options.code,
       redirect_uri: options.redirectUrl,
-      state: options.state,
     }
   );
 

diff --git a/test/exchange-web-flow-code.test.ts b/test/exchange-web-flow-code.test.ts
@@ -21,7 +21,6 @@ describe("exchangeWebFlowCode()", () => {
           client_id: "1234567890abcdef1234",
           client_secret: "1234567890abcdef12347890abcdef12345678",
           code: "code123",
-          state: "state123",
         },
       }
     );
@@ -31,7 +30,6 @@ describe("exchangeWebFlowCode()", () => {
       clientId: "1234567890abcdef1234",
       clientSecret: "1234567890abcdef12347890abcdef12345678",
       code: "code123",
-      state: "state123",
       request: request.defaults({
         headers: {
           "user-agent": "test",
@@ -78,7 +76,6 @@ describe("exchangeWebFlowCode()", () => {
           client_id: "1234567890abcdef1234",
           client_secret: "1234567890abcdef12347890abcdef12345678",
           code: "code123",
-          state: "state123",
         },
       }
     );
@@ -88,7 +85,6 @@ describe("exchangeWebFlowCode()", () => {
       clientId: "1234567890abcdef1234",
       clientSecret: "1234567890abcdef12347890abcdef12345678",
       code: "code123",
-      state: "state123",
       request: request.defaults({
         headers: {
           "user-agent": "test",
@@ -138,7 +134,6 @@ describe("exchangeWebFlowCode()", () => {
           client_id: "1234567890abcdef1234",
           client_secret: "1234567890abcdef12347890abcdef12345678",
           code: "code123",
-          state: "state123",
           redirect_uri: "https://acme-inc.com/login",
         },
       }
@@ -149,7 +144,6 @@ describe("exchangeWebFlowCode()", () => {
       clientId: "1234567890abcdef1234",
       clientSecret: "1234567890abcdef12347890abcdef12345678",
       code: "code123",
-      state: "state123",
       redirectUrl: "https://acme-inc.com/login",
       request: request.defaults({
         headers: {
@@ -198,7 +192,6 @@ describe("exchangeWebFlowCode()", () => {
           client_id: "lv1.1234567890abcdef",
           client_secret: "1234567890abcdef12347890abcdef12345678",
           code: "code123",
-          state: "state123",
           redirect_uri: "https://acme-inc.com/login",
         },
       }
@@ -209,7 +202,6 @@ describe("exchangeWebFlowCode()", () => {
       clientId: "lv1.1234567890abcdef",
       clientSecret: "1234567890abcdef12347890abcdef12345678",
       code: "code123",
-      state: "state123",
       redirectUrl: "https://acme-inc.com/login",
       request: request.defaults({
         headers: {
@@ -265,7 +257,6 @@ describe("exchangeWebFlowCode()", () => {
           client_id: "lv1.1234567890abcdef",
           client_secret: "1234567890abcdef12347890abcdef12345678",
           code: "code123",
-          state: "state123",
         },
       }
     );
@@ -275,7 +266,6 @@ describe("exchangeWebFlowCode()", () => {
       clientId: "lv1.1234567890abcdef",
       clientSecret: "1234567890abcdef12347890abcdef12345678",
       code: "code123",
-      state: "state123",
       request: request.defaults({
         headers: {
           "user-agent": "test",