Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed default export to point to dist-src instead of dist-types #736

Merged
merged 1 commit into from Apr 24, 2024

Conversation

marekdedic
Copy link
Contributor

Resolves octokit/core.js#665
Resolves octokit/core.js#667

Resolves #733 (comment)

I have tested this with jest - doesn't work before, works after :). (skaut/poptavky#1406)


Before the change?

  • Some consumers of this package could not resolve it properly (ex: jest, ts-node, tsx)

After the change?

  • Clients should be able to import the module without any errors with the fallback

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

That is really an unfortunate typo 😅

@wolfy1339 wolfy1339 merged commit 817060b into octokit:main Apr 24, 2024
8 checks passed
Copy link
Contributor

🎉 This PR is included in version 13.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@marekdedic marekdedic deleted the esm-export-typo-fix branch April 24, 2024 15:33
@marekdedic
Copy link
Contributor Author

Whoa, thanks for the fast merge :)

wolfy1339 added a commit that referenced this pull request May 2, 2024
…to the JS and not the types (#736)"

This reverts commit 817060b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
2 participants