Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: many unreleased changes to endpoint types #501

Merged
merged 1 commit into from Jan 20, 2023
Merged

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Jan 20, 2023

BREAKING CHANGE: remove defunct endpoints that no longer exist

Resolves #500

#499 was merged as a feature release, and it should have been a major release. This PR merges an empty commit to trigger a new major release


Behavior

Before the change?

  • Endpoints were removed and a major version release was not made

After the change?

  • This empty commit will trigger a new major release due to the removed endpoints

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

BREAKING CHANGE: remove defunct endpoints that no longer exist
@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented, or is being fixed Priority: High Type: Breaking change Used to note any change that requires a major version bump labels Jan 20, 2023
@ghost ghost added this to Bugs in JS Jan 20, 2023
@wolfy1339 wolfy1339 enabled auto-merge (squash) January 20, 2023 20:13
@wolfy1339 wolfy1339 merged commit dcfb6f3 into main Jan 20, 2023
JS automation moved this from Bugs to Done Jan 20, 2023
@wolfy1339 wolfy1339 deleted the major-version-bump branch January 20, 2023 20:23
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 9.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Breaking change Used to note any change that requires a major version bump Type: Bug Something isn't working as documented, or is being fixed
Projects
Archived in project
JS
  
Done
Development

Successfully merging this pull request may close these issues.

[BUG]: Release broke @octokit/plugin-rest-endpoint-methods types
3 participants