Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @octokit/types to v9 #127

Merged
merged 2 commits into from Jan 25, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 21, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@octokit/types ^8.0.0 -> ^9.0.0 age adoption passing confidence

Release Notes

octokit/types.ts

v9.0.0

Compare Source

Features
BREAKING CHANGES
  • remove defunct endpoints that no longer exist

v8.2.1

Compare Source

Bug Fixes

v8.2.0

Compare Source

Features

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 21, 2023
@ghost ghost added this to Inbox in JS Jan 21, 2023
@ghost ghost moved this from Inbox to Maintenance in JS Jan 21, 2023
@gr2m
Copy link
Contributor

gr2m commented Jan 24, 2023

@octokit/js-community any idea why these errors pop up now?

image

I feel like it must be related to octokit/types.ts#501 but the PR doesn't show any changes?

The endpoint is still in @octokit/types and also in @octokit/openapi-types. Did something change that might prevent setting the 2nd argument for some endpoints? It's very odd

@wolfy1339
Copy link
Member

wolfy1339 commented Jan 24, 2023

I feel like it must be related to octokit/types.ts#501 but the PR doesn't show any changes?

It was an empty commit to trigger a major version bump.
The actual PR that merged in the changes was octokit/types.ts#499

The endpoint is still in @octokit/types and also in @octokit/openapi-types. Did something change that might prevent setting the 2nd argument for some endpoints? It's very odd

That is odd. I don't understand why that would happen only for some endpoints and not every one

@renovate renovate bot force-pushed the renovate/octokit-types-9.x branch from 6bc3eea to 982c104 Compare January 24, 2023 23:55
@wolfy1339
Copy link
Member

$ npm ls @octokit/types
@octokit/oauth-methods@0.0.0-development
├─┬ @octokit/request-error@3.0.2
│ └── @octokit/types@8.2.1
├─┬ @octokit/request@6.2.2
│ ├─┬ @octokit/endpoint@7.0.3
│ │ └── @octokit/types@8.2.1
│ └── @octokit/types@8.2.1
├── @octokit/types@9.0.0
└─┬ semantic-release@20.0.2
  └─┬ @semantic-release/github@8.0.7
    └─┬ @octokit/rest@19.0.5
      ├─┬ @octokit/core@4.1.0
      │ ├─┬ @octokit/auth-token@3.0.2
      │ │ └── @octokit/types@8.2.1
      │ ├─┬ @octokit/graphql@5.0.4
      │ │ └── @octokit/types@8.2.1
      │ └── @octokit/types@8.2.1
      ├─┬ @octokit/plugin-paginate-rest@5.0.1
      │ └── @octokit/types@8.2.1
      └─┬ @octokit/plugin-rest-endpoint-methods@6.7.0
        └── @octokit/types@8.2.1

This is most likely why

@renovate
Copy link
Contributor Author

renovate bot commented Jan 25, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@wolfy1339
Copy link
Member

I upgraded the dependencies on @octokit/request, @octokit/request-error and updated the lock file to use a newer version of @octokit/endpoint

The problems are now resolved

@wolfy1339 wolfy1339 merged commit dc72ba0 into main Jan 25, 2023
JS automation moved this from Maintenance to Done Jan 25, 2023
@wolfy1339 wolfy1339 deleted the renovate/octokit-types-9.x branch January 25, 2023 00:10
@gr2m
Copy link
Contributor

gr2m commented Jan 25, 2023

thank you!

@github-actions
Copy link

🎉 This PR is included in version 2.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants