fix: remove obsolete events: download, follow, fork_apply, gist

octokit · Dec 11, 2018 · 9bb348f · 9bb348f
1 parent 824a21b
commit 9bb348f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 21 deletions.
diff --git a/index.json b/index.json
@@ -1188,16 +1188,6 @@
       }
     ]
   },
-  {
-    "name": "download",
-    "actions": [],
-    "examples": []
-  },
-  {
-    "name": "follow",
-    "actions": [],
-    "examples": []
-  },
   {
     "name": "fork",
     "actions": [],
@@ -1413,11 +1403,6 @@
       }
     ]
   },
-  {
-    "name": "fork_apply",
-    "actions": [],
-    "examples": []
-  },
   {
     "name": "github_app_authorization",
     "actions": [],
@@ -1447,11 +1432,6 @@
       }
     ]
   },
-  {
-    "name": "gist",
-    "actions": [],
-    "examples": []
-  },
   {
     "name": "gollum",
     "actions": [],

diff --git a/lib/check-or-update-webhooks.js b/lib/check-or-update-webhooks.js
@@ -16,7 +16,7 @@ async function checkOrUpdateWebhooks ({ cached, checkOnly }) {
 
   const html = await getHtml({ cached })
   const sections = await getSections(state, html)
-  const wekhooks = sections.map(toWebhook.bind(null, state))
+  const wekhooks = sections.map(toWebhook.bind(null, state)).filter(Boolean)
 
   const currentWebhooks = require('../index.json')
 

diff --git a/lib/section-to-webhook.js b/lib/section-to-webhook.js
@@ -5,6 +5,11 @@ const cheerio = require('cheerio')
 function sectionHtmlToWebhook (state, section) {
   const $ = cheerio.load(section.html)
 
+  // ignore obsolete events that are no longer sent
+  if (/Events of this type are no longer delivered/.test($('.warning').text())) {
+    return null
+  }
+
   const webhook = $('h3')
     .filter((index, el) => $(el).text().trim() === 'Webhook event name')
     .map((index, el) => {