fix: correct enum values for `required_conversation_resolution_leve…

…l`, add enum values for `PullRequestReview#state` (#693) ref: octokit/webhooks.net#91 ref: #689 (comment)
octokit · Aug 11, 2022 · caa9572 · caa9572
1 parent 08106ad
commit caa9572
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/payload-schemas/api.github.com/branch_protection_rule/edited.schema.json b/payload-schemas/api.github.com/branch_protection_rule/edited.schema.json
@@ -94,7 +94,7 @@
           "properties": {
             "from": {
               "type": "string",
-              "enum": ["off", "required", "requested_and_required"]
+              "enum": ["off", "non_admins", "everyone"]
             }
           },
           "additionalProperties": false

diff --git a/payload-schemas/api.github.com/pull_request_review/edited.schema.json b/payload-schemas/api.github.com/pull_request_review/edited.schema.json
@@ -61,7 +61,10 @@
           "description": "A commit SHA for the review."
         },
         "submitted_at": { "type": "string", "format": "date-time" },
-        "state": { "type": "string" },
+        "state": {
+          "type": "string",
+          "enum": ["commented", "changes_requested", "approved"]
+        },
         "html_url": { "type": "string", "format": "uri" },
         "pull_request_url": { "type": "string", "format": "uri" },
         "author_association": {

diff --git a/payload-schemas/api.github.com/pull_request_review/submitted.schema.json b/payload-schemas/api.github.com/pull_request_review/submitted.schema.json
@@ -37,7 +37,10 @@
           "description": "A commit SHA for the review."
         },
         "submitted_at": { "type": "string", "format": "date-time" },
-        "state": { "type": "string" },
+        "state": {
+          "type": "string",
+          "enum": ["commented", "changes_requested", "approved"]
+        },
         "html_url": { "type": "string", "format": "uri" },
         "pull_request_url": { "type": "string", "format": "uri" },
         "author_association": {

diff --git a/payload-types/schema.d.ts b/payload-types/schema.d.ts
@@ -822,7 +822,7 @@ export interface BranchProtectionRuleEditedEvent {
       from: number;
     };
     required_conversation_resolution_level?: {
-      from: "off" | "required" | "requested_and_required";
+      from: "off" | "non_admins" | "everyone";
     };
     required_deployments_enforcement_level?: {
       from: "off" | "non_admins" | "everyone";
@@ -5332,7 +5332,7 @@ export interface PullRequestReviewEditedEvent {
      */
     commit_id: string;
     submitted_at: string;
-    state: string;
+    state: "commented" | "changes_requested" | "approved";
     html_url: string;
     pull_request_url: string;
     author_association: AuthorAssociation;
@@ -5368,7 +5368,7 @@ export interface PullRequestReviewSubmittedEvent {
      */
     commit_id: string;
     submitted_at: string;
-    state: string;
+    state: "commented" | "changes_requested" | "approved";
     html_url: string;
     pull_request_url: string;
     author_association: AuthorAssociation;