Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct enum values for required_conversation_resolution_level, add enum values for PullRequestReview#state #693

Merged
merged 3 commits into from
Aug 11, 2022
Merged

fix: correct enum values for required_conversation_resolution_level, add enum values for PullRequestReview#state #693

merged 3 commits into from
Aug 11, 2022

Conversation

wolfy1339
Copy link
Member

No description provided.

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Aug 11, 2022
@ghost ghost added this to Bugs in JS Aug 11, 2022
nickfloyd
nickfloyd approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick ask about pull request review values... I just couldn't locate the list.

payload-schemas/api.github.com/pull_request_review/submitted.schema.json
"state": { "type": "string" },
"state": {
"type": "string",
"enum": ["commented", "changes_requested", "approved"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could never find a definitive list for this enum from the docs. After parsing it a bit I found examples using both changes_requested and approved, but I could never find comment - would you happen to be able to point me to where you found this list (schema or docs).

Definitely not a show stopper or anything - I'd just like to find out why I am missing this detail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it just by comparing payloads of webhooks I received.

A lot of things in these schemas aren't really described in the docs, and we have to infer from the payloads we receive

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it... thanks for the clarity.

@wolfy1339 wolfy1339 merged commit caa9572 into master Aug 11, 2022
@wolfy1339 wolfy1339 deleted the schema-updates branch August 11, 2022 16:06
JS automation moved this from Bugs to Done Aug 11, 2022
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 6.3.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

wolfy1339 added a commit that referenced this pull request Aug 25, 2022
@wolfy1339
fix: correct enum values for `required_conversation_resolution_leve…
17b3b07 
…l`, add enum values for `PullRequestReview#state` (#693)

ref: octokit/webhooks.net#91
ref: #689 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wolfy1339 @octokitbot @nickfloyd