Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pending_change and cancelled_pending_change #304

Merged
merged 2 commits into from
Jan 18, 2021

Conversation

wolfy1339
Copy link
Member

Ref: #301

@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Jan 17, 2021
@wolfy1339 wolfy1339 requested a review from G-Rath January 17, 2021 23:31
@ghost ghost added this to Features in JS Jan 17, 2021
Copy link
Member

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I'm happy if you want to merge this before #308, and I can just re-run that to take care of the sender changes.

"properties": {
"action": { "type": "string", "enum": ["pending_change"] },
"effective_date": { "type": "string" },
"sender": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a reference to the user common schema, as they only diff by type. See #308

"properties": {
"action": { "type": "string", "enum": ["pending_change_cancelled"] },
"effective_date": { "type": "string" },
"sender": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a reference to the user common schema, as they only diff by type. See #308

@wolfy1339 wolfy1339 merged commit e4aa9bd into master Jan 18, 2021
JS automation moved this from Features to Done Jan 18, 2021
@wolfy1339 wolfy1339 deleted the marketplace-actions branch January 18, 2021 18:41
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 3.44.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New feature or request
Projects
No open projects
JS
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants