Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing property to pull_request.{review_requested, review_request_removed} #322

Merged
merged 4 commits into from
Jan 29, 2021
Merged

fix: add missing property to pull_request.{review_requested, review_request_removed} #322

merged 4 commits into from
Jan 29, 2021

Conversation

wolfy1339
Copy link
Member

@wolfy1339 wolfy1339 commented Jan 28, 2021 •
edited

Adds 2 new payloads to help verify the edits to the schemas. (Can be ticked off in #301 once merged)

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jan 28, 2021
@ghost ghost added this to Bugs in JS Jan 28, 2021
@wolfy1339 wolfy1339 force-pushed the pull-request-requested-reviewer branch from cf47346 to 36ce7b3 Compare January 28, 2021 03:31
@wolfy1339
Copy link
Member Author

@G-Rath I've got a payload that I tried to use to validate the schema, and it didn't pass even with the schema edits. GitHub had trouble sending it in a webhook the connection timed out. The payload size is only ~29kB

Webhook payload for pull_request.review_requested 
{
  "action": "review_requested",
  "number": 902,
  "pull_request": {
    "url": "https://api.github.com/repos/hellomouse/GNS/pulls/902",
    "id": 370123640,
    "node_id": "MDExOlB1bGxSZXF1ZXN0MzcwMTIzNjQw",
    "html_url": "https://github.com/hellomouse/GNS/pull/902",
    "diff_url": "https://github.com/hellomouse/GNS/pull/902.diff",
    "patch_url": "https://github.com/hellomouse/GNS/pull/902.patch",
    "issue_url": "https://api.github.com/repos/hellomouse/GNS/issues/902",
    "number": 902,
    "state": "open",
    "locked": false,
    "title": "Test cross pr",
    "user": {
      "login": "wolfy1339",
      "id": 4595477,
      "node_id": "MDQ6VXNlcjQ1OTU0Nzc=",
      "avatar_url": "https://avatars1.githubusercontent.com/u/4595477?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/wolfy1339",
      "html_url": "https://github.com/wolfy1339",
      "followers_url": "https://api.github.com/users/wolfy1339/followers",
      "following_url": "https://api.github.com/users/wolfy1339/following{/other_user}",
      "gists_url": "https://api.github.com/users/wolfy1339/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/wolfy1339/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/wolfy1339/subscriptions",
      "organizations_url": "https://api.github.com/users/wolfy1339/orgs",
      "repos_url": "https://api.github.com/users/wolfy1339/repos",
      "events_url": "https://api.github.com/users/wolfy1339/events{/privacy}",
      "received_events_url": "https://api.github.com/users/wolfy1339/received_events",
      "type": "User",
      "site_admin": false
    },
    "body": "",
    "created_at": "2020-02-03T05:12:26Z",
    "updated_at": "2021-01-18T00:21:33Z",
    "closed_at": null,
    "merged_at": null,
    "merge_commit_sha": "ad3ef7dbb31715ea656e4f22eeaec317d39930e4",
    "assignee": null,
    "assignees": [

    ],
    "requested_reviewers": [
      {
        "login": "ohnx",
        "id": 6683648,
        "node_id": "MDQ6VXNlcjY2ODM2NDg=",
        "avatar_url": "https://avatars1.githubusercontent.com/u/6683648?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/ohnx",
        "html_url": "https://github.com/ohnx",
        "followers_url": "https://api.github.com/users/ohnx/followers",
        "following_url": "https://api.github.com/users/ohnx/following{/other_user}",
        "gists_url": "https://api.github.com/users/ohnx/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/ohnx/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/ohnx/subscriptions",
        "organizations_url": "https://api.github.com/users/ohnx/orgs",
        "repos_url": "https://api.github.com/users/ohnx/repos",
        "events_url": "https://api.github.com/users/ohnx/events{/privacy}",
        "received_events_url": "https://api.github.com/users/ohnx/received_events",
        "type": "User",
        "site_admin": false
      }
    ],
    "requested_teams": [
      {
        "name": "GNS",
        "id": 2829761,
        "node_id": "MDQ6VGVhbTI4Mjk3NjE=",
        "slug": "gns",
        "description": "GitHub Notification System for IRC",
        "privacy": "closed",
        "url": "https://api.github.com/organizations/23532486/team/2829761",
        "html_url": "https://github.com/orgs/hellomouse/teams/gns",
        "members_url": "https://api.github.com/organizations/23532486/team/2829761/members{/member}",
        "repositories_url": "https://api.github.com/organizations/23532486/team/2829761/repos",
        "permission": "pull",
        "parent": {
          "name": "JS",
          "id": 2831417,
          "node_id": "MDQ6VGVhbTI4MzE0MTc=",
          "slug": "js",
          "description": "",
          "privacy": "closed",
          "url": "https://api.github.com/organizations/23532486/team/2831417",
          "html_url": "https://github.com/orgs/hellomouse/teams/js",
          "members_url": "https://api.github.com/organizations/23532486/team/2831417/members{/member}",
          "repositories_url": "https://api.github.com/organizations/23532486/team/2831417/repos",
          "permission": "pull"
        }
      }
    ],
    "labels": [
      {
        "id": 1263184970,
        "node_id": "MDU6TGFiZWwxMjYzMTg0OTcw",
        "url": "https://api.github.com/repos/hellomouse/GNS/labels/:potato:",
        "name": ":potato:",
        "color": "814C00",
        "default": false,
        "description": "Potato"
      },
      {
        "id": 997735746,
        "node_id": "MDU6TGFiZWw5OTc3MzU3NDY=",
        "url": "https://api.github.com/repos/hellomouse/GNS/labels/bug",
        "name": "bug",
        "color": "d73a4a",
        "default": true,
        "description": "Something isn't working"
      },
      {
        "id": 997735751,
        "node_id": "MDU6TGFiZWw5OTc3MzU3NTE=",
        "url": "https://api.github.com/repos/hellomouse/GNS/labels/invalid",
        "name": "invalid",
        "color": "e4e669",
        "default": true,
        "description": "This doesn't seem right"
      }
    ],
    "milestone": null,
    "draft": false,
    "commits_url": "https://api.github.com/repos/hellomouse/GNS/pulls/902/commits",
    "review_comments_url": "https://api.github.com/repos/hellomouse/GNS/pulls/902/comments",
    "review_comment_url": "https://api.github.com/repos/hellomouse/GNS/pulls/comments{/number}",
    "comments_url": "https://api.github.com/repos/hellomouse/GNS/issues/902/comments",
    "statuses_url": "https://api.github.com/repos/hellomouse/GNS/statuses/c077b03ca3ee6bdbcf598854f7032707b9f23534",
    "head": {
      "label": "wolfy1339:test-cross-pr",
      "ref": "test-cross-pr",
      "sha": "c077b03ca3ee6bdbcf598854f7032707b9f23534",
      "user": {
        "login": "wolfy1339",
        "id": 4595477,
        "node_id": "MDQ6VXNlcjQ1OTU0Nzc=",
        "avatar_url": "https://avatars1.githubusercontent.com/u/4595477?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/wolfy1339",
        "html_url": "https://github.com/wolfy1339",
        "followers_url": "https://api.github.com/users/wolfy1339/followers",
        "following_url": "https://api.github.com/users/wolfy1339/following{/other_user}",
        "gists_url": "https://api.github.com/users/wolfy1339/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/wolfy1339/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/wolfy1339/subscriptions",
        "organizations_url": "https://api.github.com/users/wolfy1339/orgs",
        "repos_url": "https://api.github.com/users/wolfy1339/repos",
        "events_url": "https://api.github.com/users/wolfy1339/events{/privacy}",
        "received_events_url": "https://api.github.com/users/wolfy1339/received_events",
        "type": "User",
        "site_admin": false
      },
      "repo": {
        "id": 141753607,
        "node_id": "MDEwOlJlcG9zaXRvcnkxNDE3NTM2MDc=",
        "name": "GNS",
        "full_name": "wolfy1339/GNS",
        "private": false,
        "owner": {
          "login": "wolfy1339",
          "id": 4595477,
          "node_id": "MDQ6VXNlcjQ1OTU0Nzc=",
          "avatar_url": "https://avatars1.githubusercontent.com/u/4595477?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/wolfy1339",
          "html_url": "https://github.com/wolfy1339",
          "followers_url": "https://api.github.com/users/wolfy1339/followers",
          "following_url": "https://api.github.com/users/wolfy1339/following{/other_user}",
          "gists_url": "https://api.github.com/users/wolfy1339/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/wolfy1339/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/wolfy1339/subscriptions",
          "organizations_url": "https://api.github.com/users/wolfy1339/orgs",
          "repos_url": "https://api.github.com/users/wolfy1339/repos",
          "events_url": "https://api.github.com/users/wolfy1339/events{/privacy}",
          "received_events_url": "https://api.github.com/users/wolfy1339/received_events",
          "type": "User",
          "site_admin": false
        },
        "html_url": "https://github.com/wolfy1339/GNS",
        "description": "GitHub Notification Service For IRC",
        "fork": true,
        "url": "https://api.github.com/repos/wolfy1339/GNS",
        "forks_url": "https://api.github.com/repos/wolfy1339/GNS/forks",
        "keys_url": "https://api.github.com/repos/wolfy1339/GNS/keys{/key_id}",
        "collaborators_url": "https://api.github.com/repos/wolfy1339/GNS/collaborators{/collaborator}",
        "teams_url": "https://api.github.com/repos/wolfy1339/GNS/teams",
        "hooks_url": "https://api.github.com/repos/wolfy1339/GNS/hooks",
        "issue_events_url": "https://api.github.com/repos/wolfy1339/GNS/issues/events{/number}",
        "events_url": "https://api.github.com/repos/wolfy1339/GNS/events",
        "assignees_url": "https://api.github.com/repos/wolfy1339/GNS/assignees{/user}",
        "branches_url": "https://api.github.com/repos/wolfy1339/GNS/branches{/branch}",
        "tags_url": "https://api.github.com/repos/wolfy1339/GNS/tags",
        "blobs_url": "https://api.github.com/repos/wolfy1339/GNS/git/blobs{/sha}",
        "git_tags_url": "https://api.github.com/repos/wolfy1339/GNS/git/tags{/sha}",
        "git_refs_url": "https://api.github.com/repos/wolfy1339/GNS/git/refs{/sha}",
        "trees_url": "https://api.github.com/repos/wolfy1339/GNS/git/trees{/sha}",
        "statuses_url": "https://api.github.com/repos/wolfy1339/GNS/statuses/{sha}",
        "languages_url": "https://api.github.com/repos/wolfy1339/GNS/languages",
        "stargazers_url": "https://api.github.com/repos/wolfy1339/GNS/stargazers",
        "contributors_url": "https://api.github.com/repos/wolfy1339/GNS/contributors",
        "subscribers_url": "https://api.github.com/repos/wolfy1339/GNS/subscribers",
        "subscription_url": "https://api.github.com/repos/wolfy1339/GNS/subscription",
        "commits_url": "https://api.github.com/repos/wolfy1339/GNS/commits{/sha}",
        "git_commits_url": "https://api.github.com/repos/wolfy1339/GNS/git/commits{/sha}",
        "comments_url": "https://api.github.com/repos/wolfy1339/GNS/comments{/number}",
        "issue_comment_url": "https://api.github.com/repos/wolfy1339/GNS/issues/comments{/number}",
        "contents_url": "https://api.github.com/repos/wolfy1339/GNS/contents/{+path}",
        "compare_url": "https://api.github.com/repos/wolfy1339/GNS/compare/{base}...{head}",
        "merges_url": "https://api.github.com/repos/wolfy1339/GNS/merges",
        "archive_url": "https://api.github.com/repos/wolfy1339/GNS/{archive_format}{/ref}",
        "downloads_url": "https://api.github.com/repos/wolfy1339/GNS/downloads",
        "issues_url": "https://api.github.com/repos/wolfy1339/GNS/issues{/number}",
        "pulls_url": "https://api.github.com/repos/wolfy1339/GNS/pulls{/number}",
        "milestones_url": "https://api.github.com/repos/wolfy1339/GNS/milestones{/number}",
        "notifications_url": "https://api.github.com/repos/wolfy1339/GNS/notifications{?since,all,participating}",
        "labels_url": "https://api.github.com/repos/wolfy1339/GNS/labels{/name}",
        "releases_url": "https://api.github.com/repos/wolfy1339/GNS/releases{/id}",
        "deployments_url": "https://api.github.com/repos/wolfy1339/GNS/deployments",
        "created_at": "2018-07-20T20:11:57Z",
        "updated_at": "2018-07-20T20:12:00Z",
        "pushed_at": "2020-07-17T00:40:51Z",
        "git_url": "git://github.com/wolfy1339/GNS.git",
        "ssh_url": "git@github.com:wolfy1339/GNS.git",
        "clone_url": "https://github.com/wolfy1339/GNS.git",
        "svn_url": "https://github.com/wolfy1339/GNS",
        "homepage": "",
        "size": 223,
        "stargazers_count": 0,
        "watchers_count": 0,
        "language": "JavaScript",
        "has_issues": false,
        "has_projects": true,
        "has_downloads": true,
        "has_wiki": true,
        "has_pages": false,
        "forks_count": 0,
        "mirror_url": null,
        "archived": false,
        "disabled": false,
        "open_issues_count": 3,
        "license": {
          "key": "mit",
          "name": "MIT License",
          "spdx_id": "MIT",
          "url": "https://api.github.com/licenses/mit",
          "node_id": "MDc6TGljZW5zZTEz"
        },
        "forks": 0,
        "open_issues": 3,
        "watchers": 0,
        "default_branch": "master",
        "allow_squash_merge": true,
        "allow_merge_commit": true,
        "allow_rebase_merge": true,
        "delete_branch_on_merge": false
      }
    },
    "base": {
      "label": "hellomouse:master",
      "ref": "master",
      "sha": "c9b291875bed0096dbd5bf85f1726259bc1fdc44",
      "user": {
        "login": "hellomouse",
        "id": 23532486,
        "node_id": "MDEyOk9yZ2FuaXphdGlvbjIzNTMyNDg2",
        "avatar_url": "https://avatars0.githubusercontent.com/u/23532486?v=4",
        "gravatar_id": "",
        "url": "https://api.github.com/users/hellomouse",
        "html_url": "https://github.com/hellomouse",
        "followers_url": "https://api.github.com/users/hellomouse/followers",
        "following_url": "https://api.github.com/users/hellomouse/following{/other_user}",
        "gists_url": "https://api.github.com/users/hellomouse/gists{/gist_id}",
        "starred_url": "https://api.github.com/users/hellomouse/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/hellomouse/subscriptions",
        "organizations_url": "https://api.github.com/users/hellomouse/orgs",
        "repos_url": "https://api.github.com/users/hellomouse/repos",
        "events_url": "https://api.github.com/users/hellomouse/events{/privacy}",
        "received_events_url": "https://api.github.com/users/hellomouse/received_events",
        "type": "Organization",
        "site_admin": false
      },
      "repo": {
        "id": 141455128,
        "node_id": "MDEwOlJlcG9zaXRvcnkxNDE0NTUxMjg=",
        "name": "GNS",
        "full_name": "hellomouse/GNS",
        "private": false,
        "owner": {
          "login": "hellomouse",
          "id": 23532486,
          "node_id": "MDEyOk9yZ2FuaXphdGlvbjIzNTMyNDg2",
          "avatar_url": "https://avatars0.githubusercontent.com/u/23532486?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/hellomouse",
          "html_url": "https://github.com/hellomouse",
          "followers_url": "https://api.github.com/users/hellomouse/followers",
          "following_url": "https://api.github.com/users/hellomouse/following{/other_user}",
          "gists_url": "https://api.github.com/users/hellomouse/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/hellomouse/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/hellomouse/subscriptions",
          "organizations_url": "https://api.github.com/users/hellomouse/orgs",
          "repos_url": "https://api.github.com/users/hellomouse/repos",
          "events_url": "https://api.github.com/users/hellomouse/events{/privacy}",
          "received_events_url": "https://api.github.com/users/hellomouse/received_events",
          "type": "Organization",
          "site_admin": false
        },
        "html_url": "https://github.com/hellomouse/GNS",
        "description": "GitHub Notification Service For IRC. lol foo",
        "fork": false,
        "url": "https://api.github.com/repos/hellomouse/GNS",
        "forks_url": "https://api.github.com/repos/hellomouse/GNS/forks",
        "keys_url": "https://api.github.com/repos/hellomouse/GNS/keys{/key_id}",
        "collaborators_url": "https://api.github.com/repos/hellomouse/GNS/collaborators{/collaborator}",
        "teams_url": "https://api.github.com/repos/hellomouse/GNS/teams",
        "hooks_url": "https://api.github.com/repos/hellomouse/GNS/hooks",
        "issue_events_url": "https://api.github.com/repos/hellomouse/GNS/issues/events{/number}",
        "events_url": "https://api.github.com/repos/hellomouse/GNS/events",
        "assignees_url": "https://api.github.com/repos/hellomouse/GNS/assignees{/user}",
        "branches_url": "https://api.github.com/repos/hellomouse/GNS/branches{/branch}",
        "tags_url": "https://api.github.com/repos/hellomouse/GNS/tags",
        "blobs_url": "https://api.github.com/repos/hellomouse/GNS/git/blobs{/sha}",
        "git_tags_url": "https://api.github.com/repos/hellomouse/GNS/git/tags{/sha}",
        "git_refs_url": "https://api.github.com/repos/hellomouse/GNS/git/refs{/sha}",
        "trees_url": "https://api.github.com/repos/hellomouse/GNS/git/trees{/sha}",
        "statuses_url": "https://api.github.com/repos/hellomouse/GNS/statuses/{sha}",
        "languages_url": "https://api.github.com/repos/hellomouse/GNS/languages",
        "stargazers_url": "https://api.github.com/repos/hellomouse/GNS/stargazers",
        "contributors_url": "https://api.github.com/repos/hellomouse/GNS/contributors",
        "subscribers_url": "https://api.github.com/repos/hellomouse/GNS/subscribers",
        "subscription_url": "https://api.github.com/repos/hellomouse/GNS/subscription",
        "commits_url": "https://api.github.com/repos/hellomouse/GNS/commits{/sha}",
        "git_commits_url": "https://api.github.com/repos/hellomouse/GNS/git/commits{/sha}",
        "comments_url": "https://api.github.com/repos/hellomouse/GNS/comments{/number}",
        "issue_comment_url": "https://api.github.com/repos/hellomouse/GNS/issues/comments{/number}",
        "contents_url": "https://api.github.com/repos/hellomouse/GNS/contents/{+path}",
        "compare_url": "https://api.github.com/repos/hellomouse/GNS/compare/{base}...{head}",
        "merges_url": "https://api.github.com/repos/hellomouse/GNS/merges",
        "archive_url": "https://api.github.com/repos/hellomouse/GNS/{archive_format}{/ref}",
        "downloads_url": "https://api.github.com/repos/hellomouse/GNS/downloads",
        "issues_url": "https://api.github.com/repos/hellomouse/GNS/issues{/number}",
        "pulls_url": "https://api.github.com/repos/hellomouse/GNS/pulls{/number}",
        "milestones_url": "https://api.github.com/repos/hellomouse/GNS/milestones{/number}",
        "notifications_url": "https://api.github.com/repos/hellomouse/GNS/notifications{?since,all,participating}",
        "labels_url": "https://api.github.com/repos/hellomouse/GNS/labels{/name}",
        "releases_url": "https://api.github.com/repos/hellomouse/GNS/releases{/id}",
        "deployments_url": "https://api.github.com/repos/hellomouse/GNS/deployments",
        "created_at": "2018-07-18T15:36:26Z",
        "updated_at": "2021-01-07T00:10:28Z",
        "pushed_at": "2020-12-22T19:49:21Z",
        "git_url": "git://github.com/hellomouse/GNS.git",
        "ssh_url": "git@github.com:hellomouse/GNS.git",
        "clone_url": "https://github.com/hellomouse/GNS.git",
        "svn_url": "https://github.com/hellomouse/GNS",
        "homepage": "",
        "size": 5218,
        "stargazers_count": 5,
        "watchers_count": 5,
        "language": "JavaScript",
        "has_issues": true,
        "has_projects": true,
        "has_downloads": true,
        "has_wiki": false,
        "has_pages": false,
        "forks_count": 3,
        "mirror_url": null,
        "archived": false,
        "disabled": false,
        "open_issues_count": 2,
        "license": {
          "key": "mit",
          "name": "MIT License",
          "spdx_id": "MIT",
          "url": "https://api.github.com/licenses/mit",
          "node_id": "MDc6TGljZW5zZTEz"
        },
        "forks": 3,
        "open_issues": 2,
        "watchers": 5,
        "default_branch": "master",
        "allow_squash_merge": true,
        "allow_merge_commit": true,
        "allow_rebase_merge": true,
        "delete_branch_on_merge": false
      }
    },
    "_links": {
      "self": {
        "href": "https://api.github.com/repos/hellomouse/GNS/pulls/902"
      },
      "html": {
        "href": "https://github.com/hellomouse/GNS/pull/902"
      },
      "issue": {
        "href": "https://api.github.com/repos/hellomouse/GNS/issues/902"
      },
      "comments": {
        "href": "https://api.github.com/repos/hellomouse/GNS/issues/902/comments"
      },
      "review_comments": {
        "href": "https://api.github.com/repos/hellomouse/GNS/pulls/902/comments"
      },
      "review_comment": {
        "href": "https://api.github.com/repos/hellomouse/GNS/pulls/comments{/number}"
      },
      "commits": {
        "href": "https://api.github.com/repos/hellomouse/GNS/pulls/902/commits"
      },
      "statuses": {
        "href": "https://api.github.com/repos/hellomouse/GNS/statuses/c077b03ca3ee6bdbcf598854f7032707b9f23534"
      }
    },
    "author_association": "MEMBER",
    "active_lock_reason": null,
    "merged": false,
    "mergeable": true,
    "rebaseable": true,
    "mergeable_state": "unstable",
    "merged_by": null,
    "comments": 1,
    "review_comments": 1,
    "maintainer_can_modify": true,
    "commits": 3,
    "additions": 3,
    "deletions": 0,
    "changed_files": 2
  },
  "requested_reviewer": {
    "login": "ohnx",
    "id": 6683648,
    "node_id": "MDQ6VXNlcjY2ODM2NDg=",
    "avatar_url": "https://avatars1.githubusercontent.com/u/6683648?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/ohnx",
    "html_url": "https://github.com/ohnx",
    "followers_url": "https://api.github.com/users/ohnx/followers",
    "following_url": "https://api.github.com/users/ohnx/following{/other_user}",
    "gists_url": "https://api.github.com/users/ohnx/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/ohnx/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/ohnx/subscriptions",
    "organizations_url": "https://api.github.com/users/ohnx/orgs",
    "repos_url": "https://api.github.com/users/ohnx/repos",
    "events_url": "https://api.github.com/users/ohnx/events{/privacy}",
    "received_events_url": "https://api.github.com/users/ohnx/received_events",
    "type": "User",
    "site_admin": false
  },
  "repository": {
    "id": 141455128,
    "node_id": "MDEwOlJlcG9zaXRvcnkxNDE0NTUxMjg=",
    "name": "GNS",
    "full_name": "hellomouse/GNS",
    "private": false,
    "owner": {
      "login": "hellomouse",
      "id": 23532486,
      "node_id": "MDEyOk9yZ2FuaXphdGlvbjIzNTMyNDg2",
      "avatar_url": "https://avatars0.githubusercontent.com/u/23532486?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/hellomouse",
      "html_url": "https://github.com/hellomouse",
      "followers_url": "https://api.github.com/users/hellomouse/followers",
      "following_url": "https://api.github.com/users/hellomouse/following{/other_user}",
      "gists_url": "https://api.github.com/users/hellomouse/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/hellomouse/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/hellomouse/subscriptions",
      "organizations_url": "https://api.github.com/users/hellomouse/orgs",
      "repos_url": "https://api.github.com/users/hellomouse/repos",
      "events_url": "https://api.github.com/users/hellomouse/events{/privacy}",
      "received_events_url": "https://api.github.com/users/hellomouse/received_events",
      "type": "Organization",
      "site_admin": false
    },
    "html_url": "https://github.com/hellomouse/GNS",
    "description": "GitHub Notification Service For IRC. lol foo",
    "fork": false,
    "url": "https://api.github.com/repos/hellomouse/GNS",
    "forks_url": "https://api.github.com/repos/hellomouse/GNS/forks",
    "keys_url": "https://api.github.com/repos/hellomouse/GNS/keys{/key_id}",
    "collaborators_url": "https://api.github.com/repos/hellomouse/GNS/collaborators{/collaborator}",
    "teams_url": "https://api.github.com/repos/hellomouse/GNS/teams",
    "hooks_url": "https://api.github.com/repos/hellomouse/GNS/hooks",
    "issue_events_url": "https://api.github.com/repos/hellomouse/GNS/issues/events{/number}",
    "events_url": "https://api.github.com/repos/hellomouse/GNS/events",
    "assignees_url": "https://api.github.com/repos/hellomouse/GNS/assignees{/user}",
    "branches_url": "https://api.github.com/repos/hellomouse/GNS/branches{/branch}",
    "tags_url": "https://api.github.com/repos/hellomouse/GNS/tags",
    "blobs_url": "https://api.github.com/repos/hellomouse/GNS/git/blobs{/sha}",
    "git_tags_url": "https://api.github.com/repos/hellomouse/GNS/git/tags{/sha}",
    "git_refs_url": "https://api.github.com/repos/hellomouse/GNS/git/refs{/sha}",
    "trees_url": "https://api.github.com/repos/hellomouse/GNS/git/trees{/sha}",
    "statuses_url": "https://api.github.com/repos/hellomouse/GNS/statuses/{sha}",
    "languages_url": "https://api.github.com/repos/hellomouse/GNS/languages",
    "stargazers_url": "https://api.github.com/repos/hellomouse/GNS/stargazers",
    "contributors_url": "https://api.github.com/repos/hellomouse/GNS/contributors",
    "subscribers_url": "https://api.github.com/repos/hellomouse/GNS/subscribers",
    "subscription_url": "https://api.github.com/repos/hellomouse/GNS/subscription",
    "commits_url": "https://api.github.com/repos/hellomouse/GNS/commits{/sha}",
    "git_commits_url": "https://api.github.com/repos/hellomouse/GNS/git/commits{/sha}",
    "comments_url": "https://api.github.com/repos/hellomouse/GNS/comments{/number}",
    "issue_comment_url": "https://api.github.com/repos/hellomouse/GNS/issues/comments{/number}",
    "contents_url": "https://api.github.com/repos/hellomouse/GNS/contents/{+path}",
    "compare_url": "https://api.github.com/repos/hellomouse/GNS/compare/{base}...{head}",
    "merges_url": "https://api.github.com/repos/hellomouse/GNS/merges",
    "archive_url": "https://api.github.com/repos/hellomouse/GNS/{archive_format}{/ref}",
    "downloads_url": "https://api.github.com/repos/hellomouse/GNS/downloads",
    "issues_url": "https://api.github.com/repos/hellomouse/GNS/issues{/number}",
    "pulls_url": "https://api.github.com/repos/hellomouse/GNS/pulls{/number}",
    "milestones_url": "https://api.github.com/repos/hellomouse/GNS/milestones{/number}",
    "notifications_url": "https://api.github.com/repos/hellomouse/GNS/notifications{?since,all,participating}",
    "labels_url": "https://api.github.com/repos/hellomouse/GNS/labels{/name}",
    "releases_url": "https://api.github.com/repos/hellomouse/GNS/releases{/id}",
    "deployments_url": "https://api.github.com/repos/hellomouse/GNS/deployments",
    "created_at": "2018-07-18T15:36:26Z",
    "updated_at": "2021-01-07T00:10:28Z",
    "pushed_at": "2020-12-22T19:49:21Z",
    "git_url": "git://github.com/hellomouse/GNS.git",
    "ssh_url": "git@github.com:hellomouse/GNS.git",
    "clone_url": "https://github.com/hellomouse/GNS.git",
    "svn_url": "https://github.com/hellomouse/GNS",
    "homepage": "",
    "size": 5218,
    "stargazers_count": 5,
    "watchers_count": 5,
    "language": "JavaScript",
    "has_issues": true,
    "has_projects": true,
    "has_downloads": true,
    "has_wiki": false,
    "has_pages": false,
    "forks_count": 3,
    "mirror_url": null,
    "archived": false,
    "disabled": false,
    "open_issues_count": 2,
    "license": {
      "key": "mit",
      "name": "MIT License",
      "spdx_id": "MIT",
      "url": "https://api.github.com/licenses/mit",
      "node_id": "MDc6TGljZW5zZTEz"
    },
    "forks": 3,
    "open_issues": 2,
    "watchers": 5,
    "default_branch": "master"
  },
  "organization": {
    "login": "hellomouse",
    "id": 23532486,
    "node_id": "MDEyOk9yZ2FuaXphdGlvbjIzNTMyNDg2",
    "url": "https://api.github.com/orgs/hellomouse",
    "repos_url": "https://api.github.com/orgs/hellomouse/repos",
    "events_url": "https://api.github.com/orgs/hellomouse/events",
    "hooks_url": "https://api.github.com/orgs/hellomouse/hooks",
    "issues_url": "https://api.github.com/orgs/hellomouse/issues",
    "members_url": "https://api.github.com/orgs/hellomouse/members{/member}",
    "public_members_url": "https://api.github.com/orgs/hellomouse/public_members{/member}",
    "avatar_url": "https://avatars0.githubusercontent.com/u/23532486?v=4",
    "description": "we totally know what we're doing"
  },
  "sender": {
    "login": "wolfy1339",
    "id": 4595477,
    "node_id": "MDQ6VXNlcjQ1OTU0Nzc=",
    "avatar_url": "https://avatars1.githubusercontent.com/u/4595477?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/wolfy1339",
    "html_url": "https://github.com/wolfy1339",
    "followers_url": "https://api.github.com/users/wolfy1339/followers",
    "following_url": "https://api.github.com/users/wolfy1339/following{/other_user}",
    "gists_url": "https://api.github.com/users/wolfy1339/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/wolfy1339/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/wolfy1339/subscriptions",
    "organizations_url": "https://api.github.com/users/wolfy1339/orgs",
    "repos_url": "https://api.github.com/users/wolfy1339/repos",
    "events_url": "https://api.github.com/users/wolfy1339/events{/privacy}",
    "received_events_url": "https://api.github.com/users/wolfy1339/received_events",
    "type": "User",
    "site_admin": false
  }
}

@G-Rath
Copy link
Member

G-Rath commented Jan 28, 2021

image

I'll try and look into this tomorrow :)

G-Rath
G-Rath approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfy1339 I've not had any issues with the function for these events - maybe it was just a fluke at Azures end?

I think lets just merge and deploy these schema changes, and then give it another try :)

@wolfy1339 wolfy1339 merged commit d75f126 into master Jan 29, 2021
JS automation moved this from Bugs to Done Jan 29, 2021
@wolfy1339 wolfy1339 deleted the pull-request-requested-reviewer branch January 29, 2021 20:03
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 3.51.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@G-Rath G-Rath G-Rath approved these changes

@oscard0m oscard0m Awaiting requested review from oscard0m

Assignees
No one assigned
Labels
Type: Bug Something isn't working as documented
Projects
No open projects
JS
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wolfy1339 @G-Rath @octokitbot