convert command.isDisabled and isSelectionInBlockRoot #3178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original test in web_editor tested the "indentList" command. Fun fact: this command is not used anywhere in the codebase, except for the test suite... The current test has as step function `keydownTab`, which, other than indenting lists, indent non-list blocks as well. For this reason I'm adapting the test. PS: As of now, we don't have a "INDENT_LIST" command.
The plugin name should be abstracted from the implementation
Implement the colorpicker gradient tab
for nested colored elements
The Powerbox commands have a parameter to disable them in certain contexts, and many had it set on `!isSelectionInBlockRoot()` since commit [1] but since neither of these things were converted for Phoenix, many commands were missing the `isDisabled` key. This applies them in all the places that were incompletely converted but we'll need to make sure we don't forget to add them to future conversions. [1]: odoo@defce6b
|
This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.