Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master phoenix ged #3196

Merged
merged 1 commit into from
May 17, 2024
Merged

Master phoenix ged #3196

merged 1 commit into from
May 17, 2024

Conversation

ged-odoo
Copy link

No description provided.

@robodoo
Copy link

robodoo commented May 14, 2024

This PR targets the un-managed branch odoo-dev/odoo:master-phoenix, it needs to be retargeted before it can be merged.

@ged-odoo ged-odoo force-pushed the master-phoenix-ged branch 3 times, most recently from 5984f26 to 0e285e7 Compare May 15, 2024 13:37
@@ -76,16 +69,24 @@ class TestEditor extends Component {
*/
export async function setupEditor(content, options = {}) {
const config = options.config || {};
const inIFrame = "inIFrame" in options ? options.inIFrame : false;
const editor = new Editor(config);
const props = options.props || {};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clone options.props

Comment on lines +163 to +164
delete props.content;
delete props.config;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete ?

@ged-odoo ged-odoo force-pushed the master-phoenix-ged branch 2 times, most recently from 660617f to f698f90 Compare May 17, 2024 07:32
@FrancoisGe FrancoisGe merged commit c54583a into master-phoenix May 17, 2024
@FrancoisGe FrancoisGe deleted the master-phoenix-ged branch May 17, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants