[FIX] BottomBarSheet: Rename a sheet with style content on Firefox #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 Task: 3754944
hokolomopo
reviewed
Mar 25, 2024
| @@ -12,6 +12,15 @@ export let OWL_TEMPLATES: Document; | |||
| beforeAll(() => { | |||
| OWL_TEMPLATES = getParsedOwlTemplateBundle(); | |||
| setDefaultSheetViewSize(1000); | |||
| Object.defineProperty(Element.prototype, "innerText", { | |||
| get: function myProperty() { | |||
There was a problem hiding this comment.
Suggested change
| get: function myProperty() { | |
| get: function () { |
This whole syntax looks strange, but the function name doesn't seem mandatory
robodoo
pushed a commit
that referenced
this pull request
Mar 25, 2024
The issue addressed in PR #3351 unfortunately used a `contentEditable` value that is not compatible with Firefox [1] This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition. Testing required to define some properties as JSdom does not properly support the implementation of innerText (see [2]) [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/contenteditable#browser_compatibility [2]: jsdom/jsdom#1245 closes #3894 Task: 3754944 Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue addressed in PR #3351 unfortunately used a
contentEditablevalue that is not compatible with Firefox 1This revision implements the first strategy explored by the aforementioned PR by removing the full format from the contenteditable span when we stop the edition.
Testing required to define some properties as JSdom does not properly support the implementation of innerText (see 2)
Task: 3754944
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist