Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] zones: improve performances on 'positions' #4162

Closed
wants to merge 1 commit into from
Closed

[REF] zones: improve performances on 'positions' #4162

wants to merge 1 commit into from

Conversation

laa-odoo
Copy link
Collaborator

@laa-odoo laa-odoo commented May 2, 2024

Avoid using the sort function on a list of two arguments, divide the computation time on the line of code by 100

Task: 3901818

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented May 2, 2024

Pull request status dashboard.

LucasLefevre
LucasLefevre reviewed May 3, 2024
View reviewed changes
src/helpers/zones.ts Outdated Show resolved Hide resolved
@laa-odoo
[REF] zones: improve performances on 'positions'
779a168 
Avoid using the `sort` function on a lists of two arguments,
divide the computation time on the line of code by 100

Task: 3901818
@laa-odoo laa-odoo force-pushed the master-zones-imp-positions-perf-laa branch from 369f207 to 779a168 Compare May 3, 2024 12:18
LucasLefevre
LucasLefevre approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request May 10, 2024
@laa-odoo
[REF] zones: improve performances on 'positions'
5ee2cad 
Avoid using the `sort` function on a lists of two arguments,
divide the computation time on the line of code by 100

closes #4162

Task: 3901818
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
@robodoo robodoo closed this May 10, 2024
@robodoo robodoo added the 17.3 label May 10, 2024
@fw-bot fw-bot deleted the master-zones-imp-positions-perf-laa branch May 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasLefevre LucasLefevre LucasLefevre approved these changes

Assignees
No one assigned
Labels
17.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@laa-odoo @robodoo @LucasLefevre