[FIX] Notificiation: set a default notification store #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrahir
added a commit
to odoo-dev/odoo
that referenced
this pull request
May 9, 2024
Adapt the setup of the notification override following odoo/o-spreadsheet#4188 Task-3919166
rrahir
force-pushed
the
saas-17.2-min-integration-rar
branch
from
ef3f20c
to
8bcaeb7
Compare
Following the introduction of stores, the minimal setup has evolved as it requires to instanciate a some stores before the creation of a spreadsheet app. The documentation was not updated accordingly. More specifically, the only store that we required to instantiate manually was the `NotificationStore` and we had to add it to the App env as well. These last step are a pain for developpers that only want to set a quick and minimal integration. This commit sets default notification methods (raiseError, notifyUser, askConfirmation) which can be updated by calling `NotificationStore.update`. Task: 3919166
rrahir
force-pushed
the
saas-17.2-min-integration-rar
branch
from
8bcaeb7
to
c83bc22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the introduction of stores, the minimal setup has evolved as it requires to instanciate a some stores before the creation of a spreadsheet app. The documentation was not updated accordingly.
More specifically, the only store that we required to instantiate manually was the
NotificationStoreand we had to add it to the App env as well. These last step are a pain for developpers that only want to set a quick and minimal integration.This commit sets default notification methods (raiseError, notifyUser, askConfirmation) which can be updated by calling
NotificationStore.update.Task: 3918013
Description:
description of this task, what is implemented and why it is implemented that way.
Task: : TASK_ID
review checklist