[FW][FIX] mail: file viewer button colors in public page #165151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit: The fileViewer toolbar buttons displayed incorrect colors for portal users. The mail module's public assets loaded all components and their SCSS files. However, the file viewer had a separate SCSS file for dark mode button colors, which was unnecessary for portal users. Removing it would help fix the bug. After this commit: FileViewer toolbar button colors now display correctly for portal users. task-3872205 X-original-commit: b99138d
|
@maad-odoo @alexkuhn this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
alexkuhn
approved these changes
May 13, 2024
robodoo
pushed a commit
that referenced
this pull request
May 13, 2024
Before this commit: The fileViewer toolbar buttons displayed incorrect colors for portal users. The mail module's public assets loaded all components and their SCSS files. However, the file viewer had a separate SCSS file for dark mode button colors, which was unnecessary for portal users. Removing it would help fix the bug. After this commit: FileViewer toolbar button colors now display correctly for portal users. task-3872205 closes #165151 X-original-commit: b99138d Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 24, 2024
Before this commit: The fileViewer toolbar buttons displayed incorrect colors for portal users. The mail module's public assets loaded all components and their SCSS files. However, the file viewer had a separate SCSS file for dark mode button colors, which was unnecessary for portal users. Removing it would help fix the bug. After this commit: FileViewer toolbar button colors now display correctly for portal users. task-3872205 closes odoo#165151 X-original-commit: b99138d Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit:
The fileViewer toolbar buttons displayed incorrect colors for
portal users.
Reason for this behaviour
The mail module's public assets loaded all components and
their SCSS files. However, the file viewer had a separate SCSS
file for dark mode button colors, which was unnecessary for
portal users. Removing it would help fix the bug.
After this commit:
FileViewer toolbar button colors now display correctly for portal
users.
task-3872205
Forward-Port-Of: #163933