[IMP] hr_recruitment: add website module as dependency for hr_recruitment #165177
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment This commit ensures that the website module is included as a dependency for hr_recruitment. Consequently, upon installing hr_recruitment, users will also automatically gain access to the website. task-3880378
mepe-odoo
approved these changes
May 15, 2024
Bertrand2
requested changes
May 23, 2024
There was a problem hiding this comment.
Thanks for the PR!
Since hr_recruitment becomes dependant on website, that means that website_hr_recruitment doesn't have any purpose anymore 🤔 So I guess than rather than be an IMP adding a dependency on hr_recruitment, this should be a [MERGE] commit to fuse both modules together in one hr_recruitment module
|
oh, I guess I screwed up heavily. 😩 |
It's not a screw up @arpr-odoo ! 😄 Don't worry 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the website module is included as a dependency for hr_recruitment. Consequently, upon installing hr_recruitment, users will also automatically gain access to the website.
task-3880378