Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] base, l10n_jp: titles on contact. #165178

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vin-odoo
Copy link
Contributor

In multiple countries, adding honorifics near the names of your customer/vendor/… is seen as basic politeness and not doing so is considered rude. One well-known example is Japan, Korea is another country with similar needs.

As of today, Odoo has no way to do that easily, and users have no choice but to use Studio to customize the reports manually.

This feature aim to improve that by providing a standard way of providing titles when sending documents to your contacts.

This is done by adding the title to the contact qweb widget by default if it is set on the contact record.
This also adds a new field on the title model in order to define whether the title should be a prefix or a suffix.

Note that this is a simple, naive approach that may not fit all scenarios perfectly.

task id # 3272592


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@vin-odoo vin-odoo requested a review from oomsveta May 13, 2024 05:39
@robodoo
Copy link
Contributor

robodoo commented May 13, 2024

@vin-odoo
Copy link
Contributor Author

vin-odoo commented May 13, 2024

Please take a look 🙏

Original comment

There are some small imperfections with this system, for example, if you add a title to a child record of a company, and this title is a prefix.
It will then say something like "Mr. Deco Addict, Owen Wilson" but there is no easy fix for this unless we add the title to the display name, which may be too invasive and would remove the option to omit it easily.

I went with another solution using the display_name + a context key.
This allows for better flexibility and an approach that is more standard to what is done for other information, like the address, vat, ...

@C3POdoo C3POdoo added the RD research & development, internal work label May 13, 2024
@vin-odoo vin-odoo force-pushed the master-l10n_jp_honorifics-vin branch from 8a2fc81 to e5d6a89 Compare May 20, 2024 08:40
In multiple countries, adding honorifics near the names of your customer/vendor/…
is seen as basic politeness and not doing so is considered rude.
One well-known example is Japan, Korea is another country with similar needs.

As of today, Odoo has no way to do that easily, and users have no choice but
to use Studio to customize the reports manually.

This feature aim to improve that by providing a standard way of providing titles
when sending documents to your contacts.

This is done by adding the title to the contact qweb widget by default if it is
set on the contact record.
This also adds a new field on the title model in order to define whether the title
should be a prefix or a suffix.

task id # 3272592
@vin-odoo vin-odoo force-pushed the master-l10n_jp_honorifics-vin branch from e5d6a89 to 1e9865a Compare May 20, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants