[FIX] point_of_sale: restrict refund button until qty selected on ticket screen

[jipr-odoo]

Before this commit:

When clicking the refund button without selecting the quantity for the selected
order lines, the ticket screen would redirect to the product screen, resulting
in empty order lines.

After this commit:

The refund button will not redirect the ticket screen to the product screen
until a quantity is selected for the selected order line.

Task ID: 3922007

[robodoo]

Pull request status dashboard.

[adgu-odoo]

This is not a bad change but can you we have a method getHasItemsToRefund in the ticket_screen. Maybe a good change would be to use it at the start of the method. If this returns false, you just return without doing anything. This in addition with not putting the class bg-primary if the isActionButtonHighlighted props on the action_pad is false would lead to the user knowing if he can or not click on the refund button. What do you think ?

[jipr-odoo]

This is not a bad change but can you we have a method getHasItemsToRefund in the ticket_screen. Maybe a good change would be to use it at the start of the method. If this returns false, you just return without doing anything. This in addition with not putting the class bg-primary if the isActionButtonHighlighted props on the action_pad is false would lead to the user knowing if he can or not click on the refund button. What do you think ?

Hello @adgu-odoo , yes i agree with your suggestion , we can use getHasItemsToRefund() to return nothing when qty not selected for orderline , with this method we don't need highlightHeaderNote state anymore so we can remove that.

Also for isActionButtonHighlighted props on the action_pad we cannot disable the button for user as per discuss with PO here,
I think using getHasItemsToRefund() is sufficient to restrict the button from redirecting and displaying the text in red to prompt the user to enter the quantity. What do you suggest? Should I make this change?

[adgu-odoo]

This is not a bad change but can you we have a method getHasItemsToRefund in the ticket_screen. Maybe a good change would be to use it at the start of the method. If this returns false, you just return without doing anything. This in addition with not putting the class bg-primary if the isActionButtonHighlighted props on the action_pad is false would lead to the user knowing if he can or not click on the refund button. What do you think ?

Hello @adgu-odoo , yes i agree with your suggestion , we can use getHasItemsToRefund() to return nothing when qty not selected for orderline , with this method we don't need highlightHeaderNote state anymore so we can remove that.

Also for isActionButtonHighlighted props on the action_pad we cannot disable the button for user as per discuss with PO here, I think using getHasItemsToRefund() is sufficient to restrict the button from redirecting and displaying the text in red to prompt the user to enter the quantity. What do you suggest? Should I make this change?

Yeah that seems to be a good change. I do not understand why we cannot disable the button. However, if this button cannot be disabled, we should remove the isActionButtonHighlighted props (in master) as it is not used.

[jipr-odoo]

This is not a bad change but can you we have a method getHasItemsToRefund in the ticket_screen. Maybe a good change would be to use it at the start of the method. If this returns false, you just return without doing anything. This in addition with not putting the class bg-primary if the isActionButtonHighlighted props on the action_pad is false would lead to the user knowing if he can or not click on the refund button. What do you think ?

Hello @adgu-odoo , yes i agree with your suggestion , we can use getHasItemsToRefund() to return nothing when qty not selected for orderline , with this method we don't need highlightHeaderNote state anymore so we can remove that.
Also for isActionButtonHighlighted props on the action_pad we cannot disable the button for user as per discuss with PO here, I think using getHasItemsToRefund() is sufficient to restrict the button from redirecting and displaying the text in red to prompt the user to enter the quantity. What do you suggest? Should I make this change?

Yeah that seems to be a good change. I do not understand why we cannot disable the button. However, if this button cannot be disabled, we should remove the isActionButtonHighlighted props (in master) as it is not used.

Hello @adgu-odoo , we can make the button from btn-primary to btn-secondary in this case without disabling the button,
this will prompt the user to enter the quantity

[jipr-odoo]

Hello @adgu-odoo
Changes are done, can you please check again ?
Thanks!

[adgu-odoo]

I like what you did, can you just address my comment and it should be good to r+

[adgu-odoo]

Putting items there is not the best. Try with refunding a product: when clicking on refund, an order will be created with an orderline of quantity -1. If you click on a product, it will add a line with quantity 1 and the items getter will return 0 so the button will not be highlighted but it should be.

[jipr-odoo]

Thank you for bringing to my attention that I missed this particular case.

[adgu-odoo]

@robodoo r+

[fw-bot]

@jipr-odoo @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

• [FW][FIX] point_of_sale: restrict refund button until qty selected on ticket screen #166036

[fw-bot]

@jipr-odoo @adgu-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

• [FW][FIX] point_of_sale: restrict refund button until qty selected on ticket screen #166154