[FIX] stock: generate lots with import bug #165182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing a traceback JS error happening when attempting to create lot numbers with import. Odoo will try to read the value of totalReceived even though it doesn't exist. With this PR, if totalReceived is not defined, it will correctly use `props.move.data.product_qty`.
Sehnde
referenced
this pull request
May 13, 2024
This PR makes it possible to generate lot names/numbers in batch from operations in stock picking. It uses the same `count` field as generate serials to ask for a specific quantity per lot. A new field `totalReceived` is used to indicate how much is received in total. This is necessary in cases of partial reception. The value indicated in `count` will be assigned to as many lots as possible without exceeding `totalReceived`, with the leftover assigned to a last lot. The formula: `number_of_lots_generated = (totalReceived // quantity_per_lot) + 1` (if there's leftover). The rest works the same as the generate serials flow. task 3506686 closes #150707 Signed-off-by: Steve Van Essche <svs@odoo.com>
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 14, 2024
Fixing a traceback JS error happening when attempting to create lot numbers with import. Odoo will try to read the value of totalReceived even though it doesn't exist. With this PR, if totalReceived is not defined, it will correctly use `props.move.data.product_qty`. closes #165182 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a traceback JS error happening when attempting to create lot numbers with import. Odoo will try to read the value of totalReceived even though it doesn't exist.
With this PR, if totalReceived is not defined, it will correctly use
props.move.data.product_qty.I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr