Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] account*,l10n*: add named i18n parameters and escape strings #165186

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sovi-odoo
Copy link

@sovi-odoo sovi-odoo commented May 13, 2024

  • Name translated string parameters to make it possible to move them around in translations and make the translators' job a bit nicer
  • Make sure all rendered strings go through Markup or html_escape

In general, if a named parameter isn't useful to translators then it won't be added here (e.g. strings that already provide enough context with one parameter)

task-3884350

Enterprise PR: odoo/enterprise#62348

@robodoo
Copy link
Contributor

robodoo commented May 13, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label May 13, 2024
Copy link
Contributor

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments 😄 Good job ! Also not sure it's a REF, i would say it's more of an IMP

addons/account/models/account_account_tag.py Outdated Show resolved Hide resolved
addons/account_edi_ubl_cii/models/account_edi_common.py Outdated Show resolved Hide resolved
@sovi-odoo sovi-odoo changed the title [REF] account*,l10n*: add named i18n parameters and escape strings [IMP] account*,l10n*: add named i18n parameters and escape strings May 17, 2024
- Name translated string parameters to make it possible to move them
  around in translations and make the translators' job a bit nicer
- Make sure all rendered strings go through Markup or html_escape

In general, if a named parameter isn't useful to translators then it
won't be added here (e.g. strings that already provide enough context
with one parameter)

task-3884350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants