[FIX] stock: print the delivery address on slip when using packages #165194
+25
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adwid
requested changes
May 14, 2024
mathcoutant
force-pushed
the
16.0-opw-3901104-wrong_delivery_address_on_pdf-mcou
branch
4 times, most recently
from
fa2636c
to
e75ead8
Compare
mathcoutant
force-pushed
the
16.0-opw-3901104-wrong_delivery_address_on_pdf-mcou
branch
4 times, most recently
from
8668faf
to
11251e2
Compare
The delivery slip of a picking with a package doesn't print the delivery address of the partner. Steps to reproduce: 1. Go to Settings > Inventory > Operations and enable 'Packages' 2. Go to Inventory > Configuration > Warehouse Management > Operations Types 3. Open operation type 'Delivery Orders' and enable 'Show Detailed Operations' and 'Move Entire Packages' 4. Create a package: in Purchase, new RFQ, select products, confirm order, receive products, click on 'Put in Pack' and validate 5. In Inventory create a new Delivery Order, select a Delivery Address and the package you just created 6. Mark it as Done, validate and print the delivery slip 7. The delivery address is not the right one (the one selected on step 5) Cause: When creating the moves for the items in the package the partner_id is not given. So the moves don't have the field partner_id. When the method should_print_delivery_address() of stock_picking is called it returns False as self.move_ids[0].partner_id is undefined and the delivery address is not printed. Solution: Add the partner_id in _generate_moves() of stock_package_level to create the moves with the selected partner_id. opw-3901104
mathcoutant
force-pushed
the
16.0-opw-3901104-wrong_delivery_address_on_pdf-mcou
branch
from
11251e2
to
89e386a
Compare
adwid
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The delivery slip of a picking with a package doesn't print the delivery address of the partner.
Steps to reproduce:
Cause:
When creating the moves for the items in the package, the partner_id is not given. So the moves don't have the field partner_id. When the method should_print_delivery_address() of stock_picking is called, it returns False as self.move_ids[0].partner_id is undefined, and the delivery address is not printed.
Solution:
Add the partner_id in _generate_moves() of stock_package_level to create the moves with the selected partner_id.
opw-3901104
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr