[FW][FIX] tools: prevent pillow 7.0 bug on exif_transpose

[fw-bot]

On odoo.sh, in some circumstances, when uploading an image as attachment
in odoo leads to a blank image thumbnail. The same image was
successfully uploaded in the same odoo version on runbot instance.

After some investigations, it appears that the issue comes from the
python-pillow version used. A few bugs exists [0,1,2] in python-pillow
7.0.0 (packaged in ubuntu Focal) that are now fixed in version 8.1.0
[3,4,5] (packaged in Debian and specified in Odoo requirements.txt),
that causes the ImageOps.exif_transpose method to fail.

The present issue can be considered as a corner case as only images with
particular exif tags cause the issue.

The present fix is a simple workaround by first checking the presence of
the orientation tag and using it, we can avoid a call to the
exif_transpose method.

opw-2369166

[0] python-pillow/Pillow#4346
[1] python-pillow/Pillow#3973
[2] python-pillow/Pillow#4238
[3] python-pillow/Pillow#4637
[4] python-pillow/Pillow#3980
[5] python-pillow/Pillow#4009

Forward-Port-Of: #65584

[robodoo]

Pull request status dashboard.

[fw-bot]

This PR targets 14.0 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

[xmo-odoo]

@d-fence doesn't that essentially remove the use of Pillow's exif_transpose? I would expect the exif_transpose was an "optimisation" of sorts to avoid calling into our own code (if anything the Pillow version is worse as it will copy() the image even if transposition is not necessary, it will also update the EXIF metadata which we don't do and may lead to double-transposition, though the docstring states we'll save the image without EXIF data so the issue is probably limited).

At that point we might as well just remove the call to Pillow's.

[seb-odoo]

it will also update the EXIF metadata which we don't do and may lead to double-transposition, though the docstring states we'll save the image without EXIF data so the issue is probably limited).

It's actually because we don't save the EXIF that we don't bother removing it, but the Pillow approach is correct here. If the orientation of the raw data has been changed, the corresponding EXIF should be removed to avoid double-transposition potential issues.