Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove EOL nodejs versions and add new major versions, update actions dependencies #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abenhamdine
Copy link

@abenhamdine abenhamdine commented Feb 3, 2023

This PR :

  • remove nodejs version 10.x and 12.X because they are EOL and no more supported by the nodejs team (see https://github.com/nodejs/release#release-schedule). Even if many apps in the wild still use old versions of nodejs, it's generally not a good idea to keep the maintenance burden of unsupported versions. Many OSS projects drop support for these versions last months and the ecosystem is well aware of that.
  • add supports for supported major versions of nodejs thus 14, 16 and 18 (AFAIK current version 19 is not supported in nodejs images in Actions)
  • update actions node-setup, checkout and cache to last major version

@abenhamdine
Copy link
Author

First-time contributors need a maintainer to approve running workflows. Learn more.

@oguimbal could you please just approve the workflows to be runned ? thx 🙏

@oguimbal
Copy link
Owner

oguimbal commented Mar 2, 2023

Ouch, that's a nasty build error for 18.x.

Why has other builds been cancelled ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants