Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proposal issues #1986

Merged
merged 25 commits into from
May 20, 2024
Merged

Fix proposal issues #1986

merged 25 commits into from
May 20, 2024

Conversation

Silver-IT
Copy link
Member

@Silver-IT
chore: do not open new tab when user is signed in
415179d
@Silver-IT
feat: added displayName in proposals and notifications
fc8d584
@Silver-IT
fix: error in wrong icon for MINCOME_CHANGED notification
7cd625d
@Silver-IT
Merge branch 'master' into 1971-proposal-notification-using-incorrect…
a17dad1 
…-icon
@Silver-IT
feat: make one proposal when the proposal is accepted
d14417d
@Silver-IT
feat: make proposal after proposal is closed
5dea581
@Silver-IT
chore: do not open new tab when user is signed in
a996ddc
@Silver-IT
Merge branch 'master' into 1971-proposal-notification-using-incorrect…
f0f8f1d 
…-icon
@Silver-IT
feat: updated function name to have precise meaning
769da56
@Silver-IT
fix: errors in notification options
3b4d7bd
@Silver-IT
chore: do not open new tab when user is signed in
630d5ff
@Silver-IT
Merge branch 'master' into 1971-proposal-notification-using-incorrect…
9d605af 
…-icon
@Silver-IT Silver-IT requested a review from taoeffect May 8, 2024 02:13
@Silver-IT Silver-IT self-assigned this May 8, 2024
@Silver-IT Silver-IT linked an issue May 8, 2024 that may be closed by this pull request
Proposal notification using incorrect icon #1971
Closed
Silver-IT
Silver-IT commented May 8, 2024
View reviewed changes
Copy link
Member Author

@Silver-IT Silver-IT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ready!

@cypress Cypress
Copy link

cypress bot commented May 8, 2024 •
edited

Passing run #2270 ↗︎

0 111 8 0 Flakiness 0

Details:

Merge 98e8d26 into 30ecc09...
Project: group-income Commit: cc0e92fe03 ℹ️
Status: Passed Duration: 10:05 💡
Started: May 20, 2024 4:23 PM Ended: May 20, 2024 4:33 PM

Review all test suite changes for PR #1986 ↗︎

taoeffect
taoeffect requested changes May 9, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Silver-IT!

Preliminary review ready!

frontend/model/contracts/group.js Outdated Show resolved Hide resolved
frontend/views/containers/chatroom/MessageInteractive.vue Outdated Show resolved Hide resolved
frontend/views/containers/chatroom/MessageInteractive.vue Outdated Show resolved Hide resolved
frontend/views/containers/proposals/ProposalItem.vue Outdated Show resolved Hide resolved
frontend/views/containers/proposals/ProposalVoteOptions.vue Outdated Show resolved Hide resolved
taoeffect
taoeffect approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @Silver-IT!

@taoeffect taoeffect merged commit 810ddf0 into master May 20, 2024
4 checks passed
@taoeffect taoeffect deleted the 1971-proposal-notification-using-incorrect-icon branch May 20, 2024 16:37
This was referenced Jun 4, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees

@Silver-IT Silver-IT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal notifications not working properly Proposal notification using incorrect icon
2 participants
@Silver-IT @taoeffect