Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds eslint, eslint-config-vuepress for use in vuepress-theme-odyssey #674

Merged
merged 2 commits into from Sep 18, 2020

Conversation

arnoldsandoval-okta
Copy link
Contributor

@arnoldsandoval-okta arnoldsandoval-okta commented Sep 17, 2020

Adds eslint to monorepo, eslint-config-vuepress for use in vuepress-theme-odyssey (DRAFT PR is available here)

Copy link
Contributor

@jmelberg-okta jmelberg-okta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions.

Please make sure to address the yarn.lock changes before merging.

yarn.lock Outdated
@@ -49,6 +49,15 @@
jsesc "^2.5.1"
source-map "^0.5.0"

"@babel/generator@^7.11.5":
version "7.11.6"
resolved "https://artifacts.aue1d.saasure.com:443/artifactory/api/npm/npm-okta-master/@babel/generator/-/generator-7.11.6.tgz#b868900f81b163b4d464ea24545c61cbac4dc620"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be our public registry - not internal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix.

packages/vuepress-theme-odyssey/.eslintignore Outdated Show resolved Hide resolved
packages/vuepress-theme-odyssey/package.json Show resolved Hide resolved
@arnoldsandoval-okta arnoldsandoval-okta merged commit 0efaac9 into as-576-vuepress-theme-odyssey Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants