Throw error if there is incorrect relatesTo
in IDX response
#1421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is incorrect
relatesTo
in IDX response from server, it can lead to unexpected behaviour, so throw an error.In the infinite requests bug scenario remediation
select-authenticator-authenticate
was falsely selected instead ofchallenge-authenticator
, becausecanRemediate()
returns true due to mistake in line 36:okta-auth-js/lib/idx/remediators/Base/SelectAuthenticator.ts
Line 36 in 933fff3
Phone authenticator has incorrect
relatesTo: "$.authenticatorEnrollments.value[9]"
, sorelatesTo.key
is undefined andauthenticator.key
is also undefined, leading to false equality.Just adding protection against undefined to line 36 fixes infinite loop bug.
Internal ref: https://oktainc.atlassian.net/browse/OKTA-612326