Type fixes #1463
Merged
Type fixes #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredperreault-okta
approved these changes
Oct 13, 2023
Implementers cannot simply return anything and expect the client to work; they need to return a specific object in order for the client to work properly. This fixes the type definition for `HttpRequestClient` to reflect that requirement.
denysoblohin-okta
force-pushed
the
od-types-fix-OKTA-644784
branch
from
11e4506
to
abc7fcd
Compare
eng-services-aperture-github-bot-okta
deleted the
od-types-fix-OKTA-644784
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rememberMetoIdentifyValuesHttpRequestClientreturnsPromise<HttpResponse>(Copy of fix: use correct return type forHttpRequestClient#1455)