enforce element check on scrollspy target (twbs#30747)

olsza · Oct 3, 2020 · 1044bfa · 1044bfa
1 parent 18be046
commit 1044bfa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/js/src/scrollspy.js b/js/src/scrollspy.js
@@ -9,6 +9,7 @@ import {
   getjQuery,
   getSelectorFromElement,
   getUID,
+  isElement,
   typeCheckConfig
 } from './util/index'
 import Data from './dom/data'
@@ -168,7 +169,7 @@ class ScrollSpy {
       ...typeof config === 'object' && config ? config : {}
     }
 
-    if (typeof config.target !== 'string') {
+    if (typeof config.target !== 'string' && isElement(config.target)) {
       let { id } = config.target
       if (!id) {
         id = getUID(NAME)

diff --git a/site/content/docs/4.3/components/scrollspy.md b/site/content/docs/4.3/components/scrollspy.md
@@ -324,7 +324,7 @@ Options can be passed via data attributes or JavaScript. For data attributes, ap
     </tr>
     <tr>
       <td>target</td>
-      <td>string</td>
+      <td>string | jQuery object | DOM element</td>
       <td></td>
       <td>Specifies element to apply Scrollspy plugin.</td>
     </tr>