Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix woman-* and man-* short codes are now *_woman and *_man on GitHub #112

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rhysd
Copy link

@rhysd rhysd commented Nov 4, 2021

I got an issue report in my project and it turned out that it was a bug of this library.

rhysd/remark-emoji#19

This PR fixes the bug. Many man-* and woman-* short codes seem to be renamed to *_man and *_woman. For example, :man-walking: was renamed to :walking_man: 🚶🏼‍♂️. I checked all man-* and woman-* emojis on GitHub and added new short codes corresponding to them if they're existing.

According to Emojipedia,

https://emojipedia.org/man-walking/

  • :man_walking: (Emojipedia)
  • :man-walking: (Slack)
  • :walking_man: (Github)

aidenlx added a commit to aidenlx/obsidian-icon-shortcodes that referenced this pull request Nov 5, 2021
@nilsreichardt
Copy link

@omnidan Are there any plans to merge this?

@samueljim
Copy link

bump

@JoshuaKGoldberg JoshuaKGoldberg added the status: blocked Waiting for something else to be resolved label May 20, 2023
@JoshuaKGoldberg
Copy link
Collaborator

JoshuaKGoldberg commented May 20, 2023

👋 Heyall, new junior maintainer here picking up old threads - quick status update:

Marking this PR as blocked until we get clarity on what should go in emojilib vs. node-emoji. But this PR is great and I definitely want to see it land 😄 - hopefully soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Waiting for something else to be resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants