Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test is now working for 3.8 #34

Merged
merged 1 commit into from Oct 11, 2019
Merged

Conversation

ip4368
Copy link
Contributor

@ip4368 ip4368 commented Oct 10, 2019

Description

Coverage fixed the issue with multiprocessing on 4.5.4: nedbat/coveragepy#828
The other issue on PyLint/astroid is also fixed, but version bump is not needed as it is not a direct dependency: pylint-dev/astroid#675

test plan:
make lint test runs fine on 3.8rc
wait for Travis CI

Fixes: #26

@codecov
Copy link

codecov bot commented Oct 10, 2019

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files           2        2           
  Lines         245      245           
  Branches       34       34           
=======================================
  Hits          213      213           
  Misses         22       22           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e4080...2804a04. Read the comment docs.

@amyreese amyreese merged commit 1cfd7c9 into omnilib:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compatibility with Python 3.8
2 participants