Update SDK encoding/decoding for Cadence 1.0 #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5ed4763 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jribbink
commented
Apr 30, 2024
| @@ -638,6 +641,9 @@ export const Optional = < | |||
| v => v | |||
| ) | |||
|
|
|||
| /** | |||
| * @deprecated Reference values cannot be imported into the Cadence interpreter, will be removed in future versions | |||
| */ | |||
| export const Reference = typedef( | |||
There was a problem hiding this comment.
Don't know what the deal is with this... if it's a relic of the past or just a mistake altogether, because Reference values cannot be imported into the Cadence interpreter, so this will never work.
jribbink
commented
May 1, 2024
packages/types/src/types.ts
Outdated
Comment on lines
900
to
904
| (v: { | ||
| start: TypeDescriptorInput<T> | ||
| end: TypeDescriptorInput<T> | ||
| step?: TypeDescriptorInput<T> | ||
| }) => { |
There was a problem hiding this comment.
I would have prefered to use a tuple here for brevity, but it feels more explicit to use an object for the decoding, and I think there's value in encoding/decoding formats being in sync
chasefleming
reviewed
May 1, 2024
chasefleming
approved these changes
May 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1861