Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IndexService::find() adhere to its contract when document was not found #971

Open
wants to merge 1 commit into
base: 6.2
Choose a base branch
from

Conversation

jdreesen
Copy link

@jdreesen jdreesen commented Nov 4, 2020

Elasticsearch\Client::get() throws an exception when the document is not found but according to its PhpDoc ONGR\ElasticsearchBundle\Service\IndexService::find() should return null in this case.

…t found

`Elasticsearch\Client::get()` throws an exception when the document is not found but according to its PhpDoc `ONGR\ElasticsearchBundle\Service\IndexService::find()` should return `null` in this case.
@codecov-io
Copy link

codecov-io commented Nov 4, 2020

Codecov Report

Merging #971 into 6.2 will decrease coverage by 0.09%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                6.2     #971      +/-   ##
============================================
- Coverage     66.61%   66.52%   -0.10%     
- Complexity      423      424       +1     
============================================
  Files            39       39              
  Lines          1393     1395       +2     
============================================
  Hits            928      928              
- Misses          465      467       +2     
Impacted Files Coverage Δ Complexity Δ
Service/IndexService.php 63.01% <33.33%> (-0.59%) 66.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac771ff...49c394b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants