Fix test for gomega version bump #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll check it in a sec. |
Ygnas
force-pushed
the
fix-test-gomega
branch
3 times, most recently
from
688311c
to
187c928
Compare
|
Test did not like |
blgm
reviewed
Apr 22, 2024
|
thanks y’all i’ve pulled this in now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gomega error message is different now:
fail(fmt.Sprintf("Context was cancelled (cause: %s)", err))This should unblock #1390
If it would be easier I can bump the version of gomega here as well.
Verification