fix: iceStopWaitingOnServerReflexive is resetting the peerConnectionDelegate #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ectionDelegate When enabling the `iceStopWaitingOnServerReflexive` configuration and you have a custom sessionDescriptionHandler with custom peerConnectionDelegate, it gets erased. As in the code forces the delegate to be the one set when that config is enabled...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling the
iceStopWaitingOnServerReflexiveconfiguration and you have a custom sessionDescriptionHandler with custom peerConnectionDelegate, it gets erased.In the code the delegate is rewritten to the one defined, without using the original delegates.
This fix simply merges the previous peerConnectionDelegate, if exists, to the new peerConnectionDelegate.
SIP.js/src/platform/web/session-manager/session-manager.ts
Lines 573 to 576 in e9ae99c