Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing colors not using theme colors and renaming some css variables #421

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

jovica-me
Copy link
Contributor

Hello,

We previously discussed about colors and the design system is in the theme. I didn't want to make a pull request with big changes so this pull request is only focuses on using the exiting token and fully utilizing them in the code. You can see changes to each specific token in the commits.

Some of the changes:

  • Renaming some tokens.
  • Removing unnecessary classes.
  • Removing tertiary button the unused button one and renaming secondary to outline because it was never using the secondary color.
  • Removing secondary token. It was never used.
  • Cleaning up some code with unnecessary classes.

There are some places where I didn't make any changes like Pricing.astro because they can require marking new tokens outside the exiting ones.

@prototypa
Copy link
Contributor

Hi @jovica-me

We are working on a new definition of tokens.

We prefer not to mix this PR for now (lots of changes) until we study well the needs and variants we have to achieve greater flexibility in a clean way.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants