Downstream changes from Explorer UX upgrades #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just little nitpicking that it's not camel-case but simply Title Case |
hellais
reviewed
Mar 11, 2019
| maxWidth: [768, 1024, 1280] | ||
| } | ||
|
|
||
| export default Container |
There was a problem hiding this comment.
I put very little thought into what the values should be. They sound reasonable, we need to make sure they look appropriate too.
hellais
reviewed
Mar 11, 2019
| "jest-styled-components": "^6.2.0", | ||
| "react-test-renderer": "^16.5.2" | ||
| "jest": "^24.3.1", | ||
| "jest-styled-components": "^6.3.1", |
There was a problem hiding this comment.
@sarathms let's not forget to file a ticket about jest-styled-components and it blocking on us upgrading to styled-components v4.
|
I left a couple of comments on this PR, but it looks good to me and I would say it can be merged. @sarathms do you need permissions to push to npm or do you have those already? |
|
I have published this package on npm before. I will go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OONI Explorer is going through a major UX overhaul. There are some elements of the design system which are being redesigned. These will eventually land in other applications using them.