Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade styled-components to v4 #76

Merged
merged 5 commits into from
Dec 23, 2019
Merged

Conversation

sarathms
Copy link
Contributor

  • Upgrades styled-components to 4.4.1
  • Replaces enzyme with [@testing-library/react](https://testing-library.com/docs/react-testing-library/intro)
  • Migrates tests to @testing-library/react

Closes #49

We now use the '@testing-library/react' library to write tests
Because this enables a single render of the tested component
to be used for snapshot testing, style testing and DOM testing
enzyme and 'react-test-renderer' didn't allow this unless we render
the component with different renderers and convert to JSON
@sarathms sarathms self-assigned this Dec 18, 2019
@hellais hellais added this to the Sprint 2 milestone Dec 18, 2019
@hellais
Copy link
Member

hellais commented Dec 23, 2019

This looks good to me!

@hellais hellais merged commit 18b52b6 into master Dec 23, 2019
@hellais hellais deleted the upgrade/styled-components-4 branch December 23, 2019 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to styled-components@^4.0.0 blocked on jest-syled-components
2 participants