Fix noDoubleEncoding with undefined XML entities #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #16 The \S+ in the regular expression has two problems: 1. It’s greedy, so it matches something like `¬anentity<` and prevents the first `&` from being encoded. 2. It allows **any** entity to pass through unencoded, but XML only recognizes [a few](https://www.w3.org/TR/REC-xml/#sec-predefined-ent) entities. The solution here to not double encode only the few entities recognized by XML. This results in things like ` ` being encoded into `&nbsp;`, which [seems to be what we want](https://validator.w3.org/feed/docs/error/UndefinedNamedEntity.html). You may want to backport this fix to xmlbuilder.
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 15 15
Lines 1874 1874
Branches 506 506
=======================================
Hits 1859 1859
Misses 15 15
Continue to review full report at Codecov.
|
|
Great PR! Thank you. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
The
\S+in the regular expression has two problems:It’s greedy, so it matches something like
¬anentity<and prevents the first&from being encoded.It allows any entity to pass through unencoded, but XML only recognizes a few entities.
The solution here is to not double encode only the few entities recognized by XML. This results in things like
being encoded into&nbsp;, which seems to be what we want.You may want to backport this fix to xmlbuilder.