Skip to content
This repository has been archived by the owner on Jun 11, 2018. It is now read-only.

django: get_client_class: use CLIENT setting #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 5, 2016

This makes the management command (manage.py opbeat test) use any
custom client.

@blueyed
Copy link
Contributor Author

blueyed commented Jul 5, 2016

Hopefully the tests will catch the error with the initial commit.
get_client is a bit weird to understand and might be refactored, but I've restored the original behavior for now (renaming client to client_path only).

Edit: reverted to change only get_client_class.

@blueyed blueyed force-pushed the django-test-use-client-from-config branch from 9ce3e71 to 33d1978 Compare July 5, 2016 14:59
This makes the management command (`manage.py opbeat test`) use any
custom client.
@blueyed blueyed force-pushed the django-test-use-client-from-config branch from 33d1978 to 44eabfe Compare July 5, 2016 15:00
@blueyed
Copy link
Contributor Author

blueyed commented Jul 5, 2016

Well, it's borked - although it used to pass locally..

Please let me know if this is gonna fly like this anyway, and I'll look into it again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant