Skip to content
This repository has been archived by the owner on Jun 11, 2018. It is now read-only.

Django: get_data_from_request: include exception with unavailable msg #166

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Django: get_data_from_request: include exception with unavailable msg #166

wants to merge 3 commits into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 25, 2017 •
edited

TODO:

  • squash
  • test

blueyed
blueyed commented Jul 26, 2017
View reviewed changes
opbeat/contrib/django/client.py Outdated
# assume we had a partial read:
data = '<unavailable>'
data = '<unavailable ({0}: {1})>'.format(
exc.__class__.__name__, exc)
Copy link
Contributor Author

@blueyed blueyed Jul 26, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this include/use request.POST then instead maybe somehow?

@blueyed blueyed force-pushed the django-get_data_from_request-include_exception_with_unavailable_msg branch from 12c4084 to 372792e Compare July 26, 2017 11:02
@blueyed blueyed mentioned this pull request Aug 30, 2017
Open
@blueyed blueyed force-pushed the django-get_data_from_request-include_exception_with_unavailable_msg branch 2 times, most recently from 2373768 to b80a2b9 Compare September 28, 2017 16:23
@blueyed blueyed force-pushed the django-get_data_from_request-include_exception_with_unavailable_msg branch from b80a2b9 to 691bdf2 Compare September 28, 2017 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@blueyed