Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast API configured and deployed #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kjohnsoninfo
Copy link

@kjohnsoninfo kjohnsoninfo commented Jun 20, 2023

I followed the Microsoft documentation / Gina's example which created two api endpoints:
https://fast-api-test2.azurewebsites.net/sample
https://fast-api-test2.azurewebsites.net/hello/YourName

sample gives a static text response (could be changed to hello world to fit the issue acceptance criteria)
hello/YourName responds with a message that returns the user input

This is deployed to a new function app: https://portal.azure.com/#@openaus.onmicrosoft.com/resource/subscriptions/31040569-51ed-4794-b84d-d8f25a00e44b/resourceGroups/fastapitest2/providers/Microsoft.Web/sites/fast-api-test2/functionsList

@kjohnsoninfo kjohnsoninfo linked an issue Jun 20, 2023 that may be closed by this pull request
Copy link
Member

@nareddyt nareddyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks!

},
"concurrency": {
"dynamicConcurrencyEnabled": false,
"snapshotPersistenceEnabled": false
},
"functionTimeout": "00:10:00",
"extensions": {
"http":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this will affect the other functions deployed within this app, right?

Can we double check that the call to http-parser function still works? There are instructions in the readme on how to run the other functions locally. At a minimum, we should make sure the http-parser function logs that it received a request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Azure function for hello world FastAPI endpoint
2 participants