-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow #387
Add release workflow #387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the idea is good!
...I have write access to a couple of other popular packages though, so I'd like to have this first:
github/roadmap#557
Oh, of course! I'm surprised that this is still not solved. It's scheduled for Q4 so let's hope we'll have it by the end of the year... 🎉 |
Granular access tokens are now available (beta): https://github.blog/changelog/2022-12-06-limit-scope-of-npm-tokens-with-the-new-granular-access-tokens/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gotten access to the granular tokens and added one under NPM_TOKEN
.
Unfortunately, the max expiration date is limited to 365 days
We can get started with this limit 🙂 one year is enough time to see a lot of changes.
That's a great "End of Year" gift 🎉 Thank you!
Hah, true 😃 Let's see how things evolve! |
Hopefully fixed with #408 🤞 |
Adding a simple GitHub workflow which does create a GitHub release (with auto-generated changelog) and publish the NPM package on push of version tags.
With this workflow the process would then look as follows:
npm version ...
locallygit push && git push --tags
I've added safe-publish-latest as a safety measure, which makes sure the publish process will only run if the version is a valid "latest" version.
@gustavohenke This would allow me to create releases as well. Feel free to close this pull request in case you prefer to retain the sole person to do so. Otherwise, can you please create a "NPM Automation Access Token" and store it under a secret called
NPM_TOKEN
in this repo. Thanks!