Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to pnpm 8 #410

Closed
wants to merge 3 commits into from
Closed

Upgrade to pnpm 8 #410

wants to merge 3 commits into from

Conversation

paescuj
Copy link
Collaborator

@paescuj paescuj commented Mar 29, 2023

No description provided.

@paescuj
Copy link
Collaborator Author

paescuj commented Mar 29, 2023

Postponed to EOL of Node.js 14 (2023-04-30)

@paescuj paescuj marked this pull request as draft March 31, 2023 15:34
@danny007in
Copy link

danny007in commented Apr 3, 2023

better to use only latest npm
is there any special use of pnpm

@paescuj
Copy link
Collaborator Author

paescuj commented Apr 3, 2023

better to use only latest npm is there any special use of pnpm

What do you mean exactly?

@danny007in
Copy link

mean exactly?

Better to replace pnpm to latest npm

@gustavohenke
Copy link
Member

Hey @danny007in, why do you think so?

@danny007in
Copy link

danny007in commented Apr 4, 2023

Hey @danny007in, why do you think so?

Exactly that is my point, using stable npm package best option, it also links files from the global store.

@paescuj
Copy link
Collaborator Author

paescuj commented Apr 4, 2023

[...] it also links files from the global store.

Did I miss something here? I'm not aware of this. Could you share a link?

Besides that, I don't think we're going back to npm (at least for now).
It has been shown that pnpm works very well here. In particular, it has helped to greatly reduce the duration of the tests.

@danny007in
Copy link

[...] it also links files from the global store.

Did I miss something here? I'm not aware of this. Could you share a link?

Besides that, I don't think we're going back to npm (at least for now). It has been shown that pnpm works very well here. In particular, it has helped to greatly reduce the duration of the tests.

npm v9 works as pnpm now.

https://stackoverflow.com/questions/74569635/npm-9-doesnt-copy-js-files-for-local-dependencies

@paescuj paescuj added the chore label Apr 23, 2023
@paescuj paescuj added this to the v9 milestone Oct 19, 2023
@coveralls
Copy link

Coverage Status

coverage: 99.197%. remained the same when pulling c95a841 on paescuj:pnpm-8 into 77fbc03 on open-cli-tools:main.

@paescuj paescuj closed this by deleting the head repository Oct 29, 2023
Copy link
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paescuj did you not want to proceed with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants